Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AsyncTransactionManager did not propagate statement errors #516

Merged
merged 2 commits into from Oct 16, 2020

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented Oct 15, 2020

Invalid statements or other statements that would cause an error would not cause the returned ApiFuture to fail.

Fixes #514

Invalid statements or other statements that would cause an error would not cause the
returned ApiFuture to fail.

Fixes #514
@olavloite olavloite requested review from thiagotnunes and elefeint Oct 15, 2020
@olavloite olavloite requested a review from as a code owner Oct 15, 2020
@google-cla google-cla bot added the cla: yes label Oct 15, 2020
Copy link
Contributor

@elefeint elefeint left a comment

Thank you!

public void asyncTransactionManager_shouldPropagateStatementFailure()
throws ExecutionException, InterruptedException, TimeoutException {
final Statement garbledStatement =
Statement.newBuilder("INSERT INTO BOOKS (UUID, TITLE) VALUES ('123', 'Test book')jljlk")
Copy link
Contributor

@elefeint elefeint Oct 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional: use a table more commonly found in client library integration test, so future readers won't have to wonder where BOOKS came from.

@product-auto-label product-auto-label bot added the api: spanner label Oct 16, 2020
@olavloite
Copy link
Contributor Author

@olavloite olavloite commented Oct 16, 2020

The failing samples test (Java 8) is a known transient error that frequently happens with Kokoro builds.

@olavloite olavloite merged commit 4b8b845 into master Oct 16, 2020
17 of 18 checks passed
@olavloite olavloite deleted the issue-514 branch Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants