feat: adds options to the write operations #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
thiagotnunes
changed the title
Adds the possibility of adding options to the write operations and encapsulates the write response into it's own class so that we can augment the response with more fields than the commit timestamp.
thiagotnunes
force-pushed
the
write-with-options
branch
from
67a2379
to
48da5a4
Compare
Codecov Report
@@ Coverage Diff @@
## master #531 +/- ##
============================================
- Coverage 84.03% 83.88% -0.15%
- Complexity 2537 2540 +3
============================================
Files 140 141 +1
Lines 13891 13918 +27
Branches 1329 1330 +1
============================================
+ Hits 11673 11675 +2
- Misses 1674 1699 +25
Partials 544 544
Continue to review full report at Codecov.
|
Updates WriteOption to TransactionOption and changes the WriteResponse to CommitResponse.
olavloite
approved these changes
Oct 21, 2020
mayurkale22
reviewed
Oct 21, 2020
| * | ||
| * @return a response with the timestamp at which the write was committed | ||
| */ | ||
| CommitResponse writeWithOptions(Iterable<Mutation> mutations, TransactionOption... options) |
There was a problem hiding this comment.
What do you think about WriteOption in place of TransactionOption?
There was a problem hiding this comment.
Thiago and I had a short discussion about this, and we think TransactionOption is better in this case, as we intend to also use this for options that we will need for normal read/write transactions.
product-auto-label
bot
added
the
api: spanner
mayurkale22
approved these changes
Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Adds the possibility of adding options to the write operations and encapsulates the write response into its own class so that we can augment the response with more fields than the commit timestamp.
At the moment, the new methods just delegate to the existing write methods. Once we add write option implementations we should change the definition of the added methods.