Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds assembly descriptor to snippets samples #559

Merged
merged 1 commit into from Oct 28, 2020

Conversation

thiagotnunes
Copy link
Contributor

@thiagotnunes thiagotnunes commented Oct 27, 2020

Creates a jar with dependencies for the snippets samples. This is how we executed the samples in the other repository, so we are mimicking the process here.

Creates a jar with dependencies for the snippets samples. This is how we
executed the samples in the other repository, so we are mimicking the
process here.
@thiagotnunes thiagotnunes requested review from as code owners Oct 27, 2020
@google-cla google-cla bot added the cla: yes label Oct 27, 2020
@codecov
Copy link

@codecov codecov bot commented Oct 28, 2020

Codecov Report

Merging #559 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #559   +/-   ##
=========================================
  Coverage     84.05%   84.05%           
  Complexity     2503     2503           
=========================================
  Files           141      141           
  Lines         13806    13806           
  Branches       1317     1317           
=========================================
  Hits          11604    11604           
  Misses         1656     1656           
  Partials        546      546           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3c96f2...22247ec. Read the comment docs.

@thiagotnunes thiagotnunes requested review from skuruppu and olavloite Oct 28, 2020
@product-auto-label product-auto-label bot added api: spanner samples labels Oct 28, 2020
<spanner.test.instance>default-instance</spanner.test.instance>
<spanner.sample.database>mysample</spanner.sample.database>
<spanner.quickstart.database>quickstart-db
</spanner.quickstart.database>
Copy link
Contributor

@olavloite olavloite Oct 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: could this be one line

Copy link
Contributor Author

@thiagotnunes thiagotnunes Oct 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this was broken, because of the 80 characters per column checkstyle rule.

@thiagotnunes thiagotnunes merged commit d4ae85c into googleapis:master Oct 28, 2020
22 checks passed
@thiagotnunes thiagotnunes deleted the samples-assembly-jar branch Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes samples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants