feat: add support for tagging #576

mayurkale22 · 2020-11-03T05:37:07Z

Description

Add support to enable users to set tags on database operations such as reads, queries and transactions.

Background

The statistics of queries, reads and transactions in Cloud Spanner are stored. Providing tags for database operations will allow these statistics to be grouped by a tag and makes queries/transactions easily searchable by tag. This will help make the information provided by the statistics more useful.

TODO

Rebase when RequestOptions proto changes are published.

Note: samples will be handled in a separate PR.

olavloite

This approach looks generally good to me.

google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbstractReadContext.java

google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseClientImpl.java

google-cloud-spanner/src/main/java/com/google/cloud/spanner/SessionPool.java

google-cloud-spanner/src/main/java/com/google/cloud/spanner/TransactionRunnerImpl.java

google-cloud-spanner/src/test/java/com/google/cloud/spanner/OptionsTest.java

mayurkale22 · 2020-11-03T20:18:06Z

+@syeduguri Please review

thiagotnunes

Looks good to me overall

google-cloud-spanner/src/main/java/com/google/cloud/spanner/TransactionContext.java

codecov · 2020-12-30T03:30:15Z

Codecov Report

Merging #576 (6bb97a4) into master (0bc9972) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #576      +/-   ##
============================================
+ Coverage     85.18%   85.27%   +0.08%     
- Complexity     2640     2660      +20     
============================================
  Files           155      155              
  Lines         14413    14449      +36     
  Branches       1348     1362      +14     
============================================
+ Hits          12278    12321      +43     
+ Misses         1567     1561       -6     
+ Partials        568      567       -1

Impacted Files	Coverage Δ	Complexity Δ
.../com/google/cloud/spanner/AbstractReadContext.java	`87.02% <100.00%> (+0.19%)`	`47.00 <1.00> (+3.00)`
...rc/main/java/com/google/cloud/spanner/Options.java	`92.85% <100.00%> (+0.59%)`	`92.00 <4.00> (+7.00)`
...oogle/cloud/spanner/PartitionedDmlTransaction.java	`83.33% <100.00%> (+0.72%)`	`18.00 <0.00> (+3.00)`
...ain/java/com/google/cloud/spanner/SessionImpl.java	`87.20% <100.00%> (+0.30%)`	`34.00 <0.00> (+3.00)`
...om/google/cloud/spanner/TransactionRunnerImpl.java	`86.51% <100.00%> (+0.27%)`	`10.00 <0.00> (ø)`
...a/com/google/cloud/spanner/SessionPoolOptions.java	`69.53% <0.00%> (ø)`	`18.00% <0.00%> (+1.00%)`
...ain/java/com/google/cloud/spanner/SessionPool.java	`89.32% <0.00%> (+0.19%)`	`73.00% <0.00%> (+1.00%)`
...cloud/spanner/connection/ReadWriteTransaction.java	`82.38% <0.00%> (+0.27%)`	`60.00% <0.00%> (+1.00%)`
...m/google/cloud/spanner/connection/SpannerPool.java	`89.47% <0.00%> (+1.57%)`	`33.00% <0.00%> (ø%)`
.../google/cloud/spanner/AbstractLazyInitializer.java	`100.00% <0.00%> (+7.14%)`	`5.00% <0.00%> (+1.00%)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bc9972...6bb97a4. Read the comment docs.

mayurkale22 · 2020-12-30T18:51:57Z

@olavloite @thiagotnunes I re-rebased PR based on #716, I'd like to get your reviews and approval.

olavloite

I think the transaction tag feature could be simplified somewhat. See my suggestions below.

google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbstractReadContext.java

google-cloud-spanner/src/main/java/com/google/cloud/spanner/TransactionRunnerImpl.java

google-cloud-spanner/src/main/java/com/google/cloud/spanner/Options.java

google-cloud-spanner/src/main/java/com/google/cloud/spanner/TransactionRunnerImpl.java

google-cloud-spanner/src/test/java/com/google/cloud/spanner/AbstractReadContextTest.java

mayurkale22

@olavloite thanks for the suggestions. I made the necessary changes, PTAL.

google-cloud-spanner/src/test/java/com/google/cloud/spanner/AbstractReadContextTest.java

google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbstractReadContext.java

mayurkale22 · 2021-03-31T21:59:47Z

@thiagotnunes @elharo @skuruppu this is ready to review. PTAL

thiagotnunes

Just a few nits, but feel free to ignore them

thiagotnunes · 2021-03-31T23:53:12Z

google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbstractReadContext.java

+   * {@link AbstractReadContext} does not have a transaction tag.
+   */
+  @Nullable
+  String getTransactionTag() {


nit: could we also create a hasTransactionTag() that checks if getTransactionTag() != null?

google-cloud-spanner/src/test/java/com/google/cloud/spanner/OptionsTest.java

mayurkale22 · 2021-04-01T06:23:46Z

The samples build failure is unrelated to this change

google-cloud-spanner/src/test/java/com/google/cloud/spanner/OptionsTest.java

mayurkale22 requested a review from as a code owner Nov 3, 2020

product-auto-label bot added the api: spanner label Nov 3, 2020

google-cla bot added the cla: yes label Nov 3, 2020

This comment has been minimized.

Sign in to view

olavloite reviewed Nov 3, 2020

View changes

skuruppu requested a review from thiagotnunes Nov 3, 2020

This comment has been minimized.

Sign in to view

thiagotnunes reviewed Nov 3, 2020

View changes

This comment has been minimized.

Sign in to view

olavloite mentioned this pull request Nov 13, 2020

feat: add support for tagging to Connection API #623

Merged

mayurkale22 requested a review from syeduguri Nov 24, 2020

olavloite reviewed Dec 1, 2020

View changes

google-cloud-spanner/src/main/java/com/google/cloud/spanner/TransactionContext.java Outdated Show resolved Hide resolved

olavloite mentioned this pull request Dec 1, 2020

feat: support RPC priority #676

Merged

olavloite mentioned this pull request Dec 11, 2020

feat: introduce TransactionOptions and UpdateOptions #716

Merged

mayurkale22 force-pushed the tagging_support branch from c3be7ce to 540f980 Compare Dec 30, 2020

This comment has been minimized.

Sign in to view

mayurkale22 added the do not merge label Dec 30, 2020

olavloite requested changes Dec 31, 2020

View changes

mayurkale22 reviewed Jan 1, 2021

View changes

google-cloud-spanner/src/test/java/com/google/cloud/spanner/AbstractReadContextTest.java Show resolved Hide resolved

olavloite approved these changes Jan 1, 2021

View changes

elharo reviewed Jan 21, 2021

View changes

google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbstractReadContext.java Outdated Show resolved Hide resolved

google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbstractReadContext.java Outdated Show resolved Hide resolved

vi3k6i5 mentioned this pull request Mar 5, 2021

Add tagging support on database operations such as reads, queries and transactions. googleapis/python-spanner#253

Closed

mayurkale22 force-pushed the tagging_support branch from c65e1a0 to 11f4b45 Compare Mar 31, 2021

mayurkale22 added 3 commits Mar 31, 2021

[Tagging Feature] add support for tagging feature

1bf2638

fix: code reviews

552f26f

fix: combine boiler plate code

b65b544

mayurkale22 added 4 commits Mar 31, 2021

fix: use buildRequestOptions in readInternalWithOptions

f409761

refactor

65c7b4c

refactor2

c70bd6f

fix code reviews

fa5891f

mayurkale22 force-pushed the tagging_support branch from 11f4b45 to fa5891f Compare Mar 31, 2021

mayurkale22 added 2 commits Mar 31, 2021

chore: rebase requestoption proto

2a49d4f

chore: fix lint

2d7f161

mayurkale22 removed the do not merge label Mar 31, 2021

chore: add more tests

e618d6d

chore: minor style fix

1ae31ed

thiagotnunes approved these changes Mar 31, 2021

View changes

elharo reviewed Apr 1, 2021

View changes

chore: fix code reviews

6bb97a4

mayurkale22 merged commit 2a9086f into googleapis:master Apr 6, 2021
18 checks passed

mayurkale22 deleted the tagging_support branch Apr 6, 2021

mayurkale22 mentioned this pull request Apr 7, 2021

samples: add samples for tagging feature #1042

Closed

mayurkale22 mentioned this pull request Sep 30, 2021

samples: add samples for tagging feature #1478

Closed

4 tasks

googleapis / java-spanner Public

feat: add support for tagging #576

feat: add support for tagging #576

mayurkale22 commented Nov 3, 2020 •

edited

This comment has been minimized.

olavloite left a comment

This comment has been minimized.

This comment has been minimized.

mayurkale22 commented Nov 3, 2020

thiagotnunes left a comment

This comment has been minimized.

This comment has been minimized.

codecov bot commented Dec 30, 2020 •

edited

mayurkale22 commented Dec 30, 2020

olavloite left a comment

mayurkale22 left a comment

mayurkale22 commented Mar 31, 2021

thiagotnunes left a comment

thiagotnunes Mar 31, 2021

mayurkale22 commented Apr 1, 2021

googleapis / java-spanner Public

feat: add support for tagging #576

feat: add support for tagging #576

Conversation

mayurkale22 commented Nov 3, 2020 • edited

Description

Background

TODO

This comment has been minimized.

olavloite left a comment

This comment has been minimized.

This comment has been minimized.

mayurkale22 commented Nov 3, 2020

thiagotnunes left a comment

This comment has been minimized.

This comment has been minimized.

codecov bot commented Dec 30, 2020 • edited

Codecov Report

mayurkale22 commented Dec 30, 2020

olavloite left a comment

mayurkale22 left a comment

mayurkale22 commented Mar 31, 2021

thiagotnunes left a comment

thiagotnunes Mar 31, 2021

Choose a reason for hiding this comment

mayurkale22 commented Apr 1, 2021

mayurkale22 commented Nov 3, 2020 •

edited

codecov bot commented Dec 30, 2020 •

edited