Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make enums in the Connection API public #579

Merged
merged 1 commit into from Nov 5, 2020
Merged

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented Nov 4, 2020

Some enums were defined as package-private, but these were used in the public API of the Connection API. That made the specific methods in the Connection API unusable from outside the Spanner client library.

Towards googleapis/java-spanner-jdbc#253

Some enums were defined as package-private, but these were used in the
public API of the Connection API. That made the specific methods in the
Connection API unusable from outside the Spanner client library.

Towards #253
@olavloite olavloite requested a review from thiagotnunes Nov 4, 2020
@olavloite olavloite requested a review from as a code owner Nov 4, 2020
@product-auto-label product-auto-label bot added the api: spanner label Nov 4, 2020
@google-cla google-cla bot added the cla: yes label Nov 4, 2020
Copy link
Contributor

@thiagotnunes thiagotnunes left a comment

LGTM

@olavloite
Copy link
Contributor Author

@olavloite olavloite commented Nov 5, 2020

Build failures for the samples are not related to this change.

@olavloite olavloite merged commit 19b1629 into master Nov 5, 2020
17 of 19 checks passed
@olavloite olavloite deleted the make-enums-public branch Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants