Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add descriptions for connection URL properties #609

Merged
merged 1 commit into from Nov 9, 2020

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented Nov 8, 2020

Adds descriptions for the supported connection URL properties. These can be picked up by the JDBC driver and shown as descriptions for java.sql.DriverPropertyInfo.

Adds descriptions for the supported connection URL properties. These can be
picked up by the JDBC driver and shown as descriptions for java.sql.DriverPropertyInfo.
@olavloite olavloite requested a review from thiagotnunes Nov 8, 2020
@olavloite olavloite requested a review from as a code owner Nov 8, 2020
@google-cla google-cla bot added the cla: yes label Nov 8, 2020
@product-auto-label product-auto-label bot added the api: spanner label Nov 8, 2020
Copy link
Contributor

@thiagotnunes thiagotnunes left a comment

Thanks for fixing this!

@codecov
Copy link

@codecov codecov bot commented Nov 8, 2020

Codecov Report

Merging #609 (3bdbe97) into master (c440cd8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #609   +/-   ##
=========================================
  Coverage     84.05%   84.05%           
- Complexity     2502     2503    +1     
=========================================
  Files           141      141           
  Lines         13806    13806           
  Branches       1317     1317           
=========================================
  Hits          11604    11604           
  Misses         1656     1656           
  Partials        546      546           
Impacted Files Coverage Δ Complexity Δ
...le/cloud/spanner/connection/ConnectionOptions.java 86.66% <100.00%> (ø) 61.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c440cd8...3bdbe97. Read the comment docs.

@thiagotnunes thiagotnunes merged commit 34221d7 into master Nov 9, 2020
21 checks passed
@thiagotnunes thiagotnunes deleted the add-connection-property-descriptions branch Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants