Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop sending RPCs on InstanceNotFound #61

Merged
merged 1 commit into from Feb 6, 2020
Merged

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented Feb 5, 2020

The session pool should handle InstanceNotFound in the same way as DatabaseNotFound errors, i.e. stop sending RPCs and also consider an instance that has been re-created with the same name
as a different instance, and hence require the user to re-create any database client before it can be used again.

Fixes #60

The session pool should handle InstanceNotFound in the same way
as DatabaseNotFound errors, i.e. stop sending RPCs and also
consider an instance that has been re-created with the same name
as a different instance, and hence require the user to re-create
any database client before it can be used again.

Fixes #60
@googlebot googlebot added the cla: yes label Feb 5, 2020
@olavloite olavloite added the kokoro:force-run label Feb 5, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Feb 5, 2020
@olavloite olavloite added the kokoro:force-run label Feb 5, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Feb 5, 2020
@olavloite olavloite requested review from skuruppu and hengfengli Feb 5, 2020
@skuruppu skuruppu merged commit 7618ac8 into master Feb 6, 2020
12 checks passed
@skuruppu skuruppu deleted the instance-not-found branch Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants