Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updates project / instance for samples tests #613

Conversation

thiagotnunes
Copy link
Contributor

@thiagotnunes thiagotnunes commented Nov 10, 2020

Updates the project and instance for the samples tests, so that they use the same configuration as the integration tests.

Fixes #606

Updates the project and instance for the samples tests, so that they use
the same configuration as the integration tests.
@thiagotnunes thiagotnunes requested review from as code owners Nov 10, 2020
@generated-files-bot
Copy link

@generated-files-bot generated-files-bot bot commented Nov 10, 2020

Warning: This pull request is touching the following templated files:

  • .kokoro/nightly/samples.cfg
  • .kokoro/presubmit/samples.cfg
  • samples/install-without-bom/pom.xml
  • samples/snapshot/pom.xml
  • samples/snippets/pom.xml

@google-cla google-cla bot added the cla: yes label Nov 10, 2020
@product-auto-label product-auto-label bot added the api: spanner label Nov 10, 2020
@generated-files-bot
Copy link

@generated-files-bot generated-files-bot bot commented Nov 10, 2020

Warning: This pull request is touching the following templated files:

  • .kokoro/nightly/samples.cfg
  • .kokoro/presubmit/samples.cfg
  • samples/install-without-bom/pom.xml
  • samples/snapshot/pom.xml
  • samples/snippets/pom.xml

@thiagotnunes thiagotnunes force-pushed the update-samples-tests-projects-instances branch from 42accee to 90ebe33 Compare Nov 10, 2020
@generated-files-bot
Copy link

@generated-files-bot generated-files-bot bot commented Nov 10, 2020

Warning: This pull request is touching the following templated files:

  • .kokoro/nightly/samples.cfg
  • .kokoro/presubmit/samples.cfg
  • samples/install-without-bom/pom.xml
  • samples/snapshot/pom.xml
  • samples/snippets/pom.xml

Creates the quickstart database for the integration test.
@thiagotnunes thiagotnunes requested a review from Nov 11, 2020
@generated-files-bot
Copy link

@generated-files-bot generated-files-bot bot commented Nov 11, 2020

Warning: This pull request is touching the following templated files:

  • .kokoro/nightly/samples.cfg
  • .kokoro/presubmit/samples.cfg
  • samples/install-without-bom/pom.xml
  • samples/snapshot/pom.xml
  • samples/snippets/pom.xml

@codecov
Copy link

@codecov codecov bot commented Nov 11, 2020

Codecov Report

Merging #613 (adf1b53) into master (d5ebf7e) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #613      +/-   ##
============================================
+ Coverage     84.05%   84.06%   +0.01%     
- Complexity     2502     2504       +2     
============================================
  Files           141      141              
  Lines         13806    13806              
  Branches       1317     1317              
============================================
+ Hits          11604    11606       +2     
+ Misses         1656     1654       -2     
  Partials        546      546              
Impacted Files Coverage Δ Complexity Δ
.../google/cloud/spanner/SpannerExceptionFactory.java 82.92% <0.00%> (+2.43%) 40.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5ebf7e...adf1b53. Read the comment docs.

@thiagotnunes thiagotnunes merged commit 2589e7d into googleapis:master Nov 11, 2020
22 checks passed
@thiagotnunes thiagotnunes deleted the update-samples-tests-projects-instances branch Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants