Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete stale sample databases #622

Merged
merged 1 commit into from Nov 17, 2020
Merged

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented Nov 13, 2020

Delete stale sample databases. This is the same change as in GoogleCloudPlatform/java-docs-samples#4133.

Fixes #585

@olavloite olavloite requested a review from thiagotnunes Nov 13, 2020
@olavloite olavloite requested a review from as a code owner Nov 13, 2020
@olavloite olavloite requested a review from Nov 13, 2020
@google-cla google-cla bot added the cla: yes label Nov 13, 2020
@product-auto-label product-auto-label bot added the api: spanner label Nov 13, 2020
@codecov
Copy link

@codecov codecov bot commented Nov 13, 2020

Codecov Report

Merging #622 (e77f98f) into master (3fa7910) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #622      +/-   ##
============================================
- Coverage     84.05%   84.04%   -0.01%     
  Complexity     2503     2503              
============================================
  Files           141      141              
  Lines         13806    13810       +4     
  Branches       1317     1318       +1     
============================================
+ Hits          11604    11607       +3     
- Misses         1656     1657       +1     
  Partials        546      546              
Impacted Files Coverage Δ Complexity Δ
...ud/spanner/SessionPoolAsyncTransactionManager.java 85.36% <0.00%> (-1.19%) 11.00% <0.00%> (ø%)
...le/cloud/spanner/TransactionContextFutureImpl.java 91.57% <0.00%> (+0.08%) 4.00% <0.00%> (ø%)
...gle/cloud/spanner/AsyncTransactionManagerImpl.java 71.42% <0.00%> (+1.00%) 12.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fa7910...e77f98f. Read the comment docs.

@product-auto-label product-auto-label bot added the samples label Nov 16, 2020
@olavloite olavloite merged commit 7584baa into master Nov 17, 2020
20 of 21 checks passed
@olavloite olavloite deleted the cleanup-stale-sample-databases branch Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes samples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants