Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: does not generate codeowners #631

Merged
merged 1 commit into from Nov 18, 2020
Merged

fix: does not generate codeowners #631

merged 1 commit into from Nov 18, 2020

Conversation

thiagotnunes
Copy link
Contributor

@thiagotnunes thiagotnunes commented Nov 16, 2020

Prevents the re-generation of the github CODEOWNERS file, since we have updated the owners for the samples directory.

Prevents the re-generation of the github CODEOWNERS file.
@thiagotnunes thiagotnunes requested review from as code owners Nov 16, 2020
@product-auto-label product-auto-label bot added the api: spanner label Nov 16, 2020
@google-cla google-cla bot added the cla: yes label Nov 16, 2020
@thiagotnunes thiagotnunes requested review from olavloite and skuruppu Nov 16, 2020
@codecov
Copy link

@codecov codecov bot commented Nov 16, 2020

Codecov Report

Merging #631 (9872de3) into master (e40b9ed) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #631      +/-   ##
============================================
+ Coverage     84.04%   84.06%   +0.02%     
- Complexity     2502     2505       +3     
============================================
  Files           141      141              
  Lines         13810    13810              
  Branches       1318     1318              
============================================
+ Hits          11606    11609       +3     
+ Misses         1657     1656       -1     
+ Partials        547      545       -2     
Impacted Files Coverage Δ Complexity Δ
...ud/spanner/SessionPoolAsyncTransactionManager.java 86.99% <0.00%> (+1.62%) 13.00% <0.00%> (+2.00%)
.../google/cloud/spanner/AbstractLazyInitializer.java 100.00% <0.00%> (+7.14%) 5.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e40b9ed...9872de3. Read the comment docs.

@thiagotnunes thiagotnunes merged commit 9e133a9 into master Nov 18, 2020
21 checks passed
@thiagotnunes thiagotnunes deleted the ignores-codeowners branch Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants