Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: skip failing backup tests for now" #634

merged 1 commit into from Nov 17, 2020


Copy link

@thiagotnunes thiagotnunes commented Nov 17, 2020

These tests were previously disabled due to a bug in production, which has been fixed.

@thiagotnunes thiagotnunes requested a review from as a code owner Nov 17, 2020
@google-cla google-cla bot added the cla: yes label Nov 17, 2020
@product-auto-label product-auto-label bot added the api: spanner label Nov 17, 2020
@thiagotnunes thiagotnunes requested review from olavloite and skuruppu Nov 17, 2020
Copy link

@codecov codecov bot commented Nov 17, 2020

Codecov Report

Merging #634 (1686935) into master (373981c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #634   +/-   ##
  Coverage     84.04%   84.04%           
- Complexity     2502     2503    +1     
  Files           141      141           
  Lines         13810    13810           
  Branches       1318     1318           
  Hits          11607    11607           
  Misses         1657     1657           
  Partials        546      546           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 373981c...1686935. Read the comment docs.

@thiagotnunes thiagotnunes merged commit b22cd7d into googleapis:master Nov 17, 2020
21 checks passed
@thiagotnunes thiagotnunes deleted the re-enable-backup-tests branch Nov 17, 2020
@release-please release-please bot mentioned this pull request Nov 17, 2020
gcf-merge-on-green bot pushed a commit that referenced this issue Nov 17, 2020
🤖 I have created a release \*beep\* \*boop\* 
### [3.0.4]( (2020-11-17)

### Reverts

* Revert "fix: skip failing backup tests for now" (#634) ([b22cd7d](, closes [#634](

This PR was generated with [Release Please](
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
api: spanner cla: yes
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants