Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for instance processing units #665

Merged
merged 13 commits into from Jun 21, 2021
Merged

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented Nov 19, 2020

No description provided.

@olavloite olavloite added the do not merge label Nov 19, 2020
@olavloite olavloite requested review from thiagotnunes and skuruppu Nov 19, 2020
@olavloite olavloite requested a review from as a code owner Nov 19, 2020
@olavloite olavloite requested a review from Nov 19, 2020
@olavloite olavloite requested a review from as a code owner Nov 19, 2020
@generated-files-bot
Copy link

@generated-files-bot generated-files-bot bot commented Nov 19, 2020

Warning: This pull request is touching the following templated files:

  • .github/workflows/approve-readme.yaml
  • .github/workflows/auto-release.yaml
  • .github/workflows/formatting.yaml
  • google-cloud-spanner/src/test/java/com/google/cloud/spanner/admin/instance/v1/InstanceAdminClientTest.java
  • proto-google-cloud-spanner-admin-instance-v1/src/main/java/com/google/spanner/admin/instance/v1/Instance.java
  • proto-google-cloud-spanner-admin-instance-v1/src/main/java/com/google/spanner/admin/instance/v1/InstanceOrBuilder.java
  • proto-google-cloud-spanner-admin-instance-v1/src/main/java/com/google/spanner/admin/instance/v1/SpannerInstanceAdminProto.java
  • proto-google-cloud-spanner-admin-instance-v1/src/main/proto/google/spanner/admin/instance/v1/spanner_instance_admin.proto
  • samples/snippets/pom.xml

@product-auto-label product-auto-label bot added the api: spanner label Nov 19, 2020
@google-cla google-cla bot added the cla: yes label Nov 19, 2020
@snippet-bot
Copy link

@snippet-bot snippet-bot bot commented Nov 19, 2020

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Copy link
Contributor

@thiagotnunes thiagotnunes left a comment

LGTM

@generated-files-bot
Copy link

@generated-files-bot generated-files-bot bot commented Dec 5, 2020

Warning: This pull request is touching the following templated files:

  • google-cloud-spanner/src/test/java/com/google/cloud/spanner/admin/instance/v1/InstanceAdminClientTest.java
  • proto-google-cloud-spanner-admin-instance-v1/src/main/java/com/google/spanner/admin/instance/v1/Instance.java
  • proto-google-cloud-spanner-admin-instance-v1/src/main/java/com/google/spanner/admin/instance/v1/InstanceOrBuilder.java
  • proto-google-cloud-spanner-admin-instance-v1/src/main/java/com/google/spanner/admin/instance/v1/SpannerInstanceAdminProto.java
  • proto-google-cloud-spanner-admin-instance-v1/src/main/proto/google/spanner/admin/instance/v1/spanner_instance_admin.proto

google-cloud-spanner/clirr-ignored-differences.xml Outdated Show resolved Hide resolved
@generated-files-bot
Copy link

@generated-files-bot generated-files-bot bot commented Feb 4, 2021

Warning: This pull request is touching the following templated files:

  • google-cloud-spanner/src/test/java/com/google/cloud/spanner/admin/instance/v1/InstanceAdminClientTest.java
  • proto-google-cloud-spanner-admin-instance-v1/src/main/java/com/google/spanner/admin/instance/v1/Instance.java
  • proto-google-cloud-spanner-admin-instance-v1/src/main/java/com/google/spanner/admin/instance/v1/InstanceOrBuilder.java
  • proto-google-cloud-spanner-admin-instance-v1/src/main/java/com/google/spanner/admin/instance/v1/SpannerInstanceAdminProto.java
  • proto-google-cloud-spanner-admin-instance-v1/src/main/proto/google/spanner/admin/instance/v1/spanner_instance_admin.proto

@codecov
Copy link

@codecov codecov bot commented Feb 4, 2021

Codecov Report

Merging #665 (b164d50) into master (cd45643) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Current head b164d50 differs from pull request most recent head 5c462ae. Consider uploading reports for the commit 5c462ae to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master     #665      +/-   ##
============================================
+ Coverage     84.86%   84.91%   +0.04%     
- Complexity     2762     2769       +7     
============================================
  Files           156      156              
  Lines         14318    14335      +17     
  Branches       1377     1379       +2     
============================================
+ Hits          12151    12172      +21     
+ Misses         1596     1592       -4     
  Partials        571      571              
Impacted Files Coverage Δ
...c/main/java/com/google/cloud/spanner/Instance.java 82.25% <100.00%> (+0.90%) ⬆️
.../google/cloud/spanner/InstanceAdminClientImpl.java 89.87% <100.00%> (+0.39%) ⬆️
...in/java/com/google/cloud/spanner/InstanceInfo.java 97.91% <100.00%> (+2.62%) ⬆️
...a/com/google/cloud/spanner/SessionPoolOptions.java 69.53% <0.00%> (ø)
...ain/java/com/google/cloud/spanner/SessionPool.java 88.75% <0.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e1df84...5c462ae. Read the comment docs.

@google-cla
Copy link

@google-cla google-cla bot commented May 6, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels May 6, 2021
@google-cla google-cla bot added cla: yes and removed cla: no labels May 6, 2021
Due to master merge the compilation was failing. Fixes the builder
construction here.
Adds default implementation for the InstanceInfo set processing units in
order to avoid a breaking change.
Removes the LCI samples for now, because they won't compile. We will
re-add them once the main implementation is released.
@thiagotnunes thiagotnunes requested a review from elharo Jun 18, 2021
elharo
elharo approved these changes Jun 18, 2021
@thiagotnunes thiagotnunes removed the do not merge label Jun 21, 2021
@thiagotnunes thiagotnunes merged commit 9c1c8e9 into master Jun 21, 2021
17 checks passed
@thiagotnunes thiagotnunes deleted the processing-units branch Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants