feat!: customer-managed encryption keys for Spanner #666

thiagotnunes · 2020-11-23T02:21:35Z

Implements CMEK functionality for Spanner.

generated-files-bot · 2020-11-23T02:21:39Z

Warning: This pull request is touching the following templated files:

.github/workflows/approve-readme.yaml
.github/workflows/auto-release.yaml
.github/workflows/formatting.yaml
.kokoro/common.sh
.kokoro/release/stage.sh
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/Backup.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/BackupOrBuilder.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/BackupProto.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/CommonProto.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/CreateBackupRequest.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/CreateBackupRequestOrBuilder.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/CreateDatabaseRequest.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/CreateDatabaseRequestOrBuilder.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/Database.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/DatabaseOrBuilder.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/RestoreDatabaseRequest.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/RestoreDatabaseRequestOrBuilder.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/SpannerDatabaseAdminProto.java

google-cla · 2020-11-23T02:21:42Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

generated-files-bot · 2020-11-23T02:29:31Z

Warning: This pull request is touching the following templated files:

.github/workflows/approve-readme.yaml
.github/workflows/auto-release.yaml
.github/workflows/formatting.yaml
.kokoro/common.sh
.kokoro/release/stage.sh
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/Backup.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/BackupOrBuilder.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/BackupProto.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/CommonProto.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/CreateBackupRequest.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/CreateBackupRequestOrBuilder.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/CreateDatabaseRequest.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/CreateDatabaseRequestOrBuilder.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/Database.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/DatabaseOrBuilder.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/RestoreDatabaseRequest.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/RestoreDatabaseRequestOrBuilder.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/SpannerDatabaseAdminProto.java

google-cla · 2020-11-23T02:29:35Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

codecov · 2020-11-23T02:56:48Z

Codecov Report

Merging #666 (09fb850) into master (13c297b) will decrease coverage by 0.12%.
The diff coverage is 76.09%.

@@             Coverage Diff              @@
##             master     #666      +/-   ##
============================================
- Coverage     85.22%   85.09%   -0.13%     
- Complexity     2650     2702      +52     
============================================
  Files           145      154       +9     
  Lines         14358    14555     +197     
  Branches       1391     1413      +22     
============================================
+ Hits          12236    12386     +150     
- Misses         1539     1569      +30     
- Partials        583      600      +17

Impacted Files	Coverage Δ	Complexity Δ
...va/com/google/cloud/spanner/spi/v1/SpannerRpc.java	`76.47% <ø> (ø)`	`0.00 <0.00> (ø)`
...ud/spanner/encryption/GoogleDefaultEncryption.java	`50.00% <50.00%> (ø)`	`1.00 <1.00> (?)`
.../cloud/spanner/encryption/UseBackupEncryption.java	`50.00% <50.00%> (ø)`	`1.00 <1.00> (?)`
...loud/spanner/encryption/UseDatabaseEncryption.java	`50.00% <50.00%> (ø)`	`1.00 <1.00> (?)`
...in/java/com/google/cloud/spanner/DatabaseInfo.java	`68.42% <55.55%> (+1.75%)`	`10.00 <1.00> (+2.00)`
...oogle/cloud/spanner/encryption/EncryptionInfo.java	`59.09% <59.09%> (ø)`	`7.00 <7.00> (?)`
.../spanner/encryption/CustomerManagedEncryption.java	`66.66% <66.66%> (ø)`	`6.00 <6.00> (?)`
...rc/main/java/com/google/cloud/spanner/Restore.java	`67.85% <67.85%> (ø)`	`7.00 <7.00> (?)`
...m/google/cloud/spanner/spi/v1/GapicSpannerRpc.java	`81.08% <73.46%> (-0.81%)`	`82.00 <3.00> (-1.00)`
...main/java/com/google/cloud/spanner/BackupInfo.java	`84.00% <75.00%> (+0.39%)`	`15.00 <3.00> (+3.00)`
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13c297b...09fb850. Read the comment docs.

generated-files-bot · 2020-11-24T05:34:20Z

Warning: This pull request is touching the following templated files:

.github/workflows/approve-readme.yaml
.github/workflows/auto-release.yaml
.github/workflows/formatting.yaml
.kokoro/common.sh
.kokoro/release/stage.sh
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/Backup.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/BackupOrBuilder.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/BackupProto.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/CommonProto.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/CreateBackupRequest.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/CreateBackupRequestOrBuilder.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/CreateDatabaseRequest.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/CreateDatabaseRequestOrBuilder.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/Database.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/DatabaseOrBuilder.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/RestoreDatabaseRequest.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/RestoreDatabaseRequestOrBuilder.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/SpannerDatabaseAdminProto.java

google-cla · 2020-11-24T05:34:22Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITCmek.java

generated-files-bot · 2020-11-24T05:57:21Z

Warning: This pull request is touching the following templated files:

.github/workflows/approve-readme.yaml
.github/workflows/auto-release.yaml
.github/workflows/formatting.yaml
.kokoro/common.sh
.kokoro/release/stage.sh
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/Backup.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/BackupOrBuilder.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/BackupProto.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/CommonProto.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/CreateBackupRequest.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/CreateBackupRequestOrBuilder.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/CreateDatabaseRequest.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/CreateDatabaseRequestOrBuilder.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/Database.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/DatabaseOrBuilder.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/RestoreDatabaseRequest.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/RestoreDatabaseRequestOrBuilder.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/SpannerDatabaseAdminProto.java

google-cla · 2020-11-24T05:57:27Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITCmek.java

generated-files-bot · 2020-11-24T07:18:27Z

Warning: This pull request is touching the following templated files:

.kokoro/common.sh
.kokoro/release/stage.sh
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/Backup.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/BackupOrBuilder.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/BackupProto.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/CommonProto.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/CreateBackupRequest.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/CreateBackupRequestOrBuilder.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/CreateDatabaseRequest.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/CreateDatabaseRequestOrBuilder.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/Database.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/DatabaseOrBuilder.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/RestoreDatabaseRequest.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/RestoreDatabaseRequestOrBuilder.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/SpannerDatabaseAdminProto.java

google-cla · 2020-11-24T07:18:33Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

olavloite

Small question on whether we should use the wrapper or proto class, otherwise LGTM.

google-cloud-spanner/src/main/java/com/google/cloud/spanner/BackupInfo.java

generated-files-bot · 2020-11-26T01:30:19Z

Warning: This pull request is touching the following templated files:

.kokoro/common.sh
.kokoro/release/stage.sh
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/Backup.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/BackupOrBuilder.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/BackupProto.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/CommonProto.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/CreateBackupRequest.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/CreateBackupRequestOrBuilder.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/CreateDatabaseRequest.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/CreateDatabaseRequestOrBuilder.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/Database.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/DatabaseOrBuilder.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/RestoreDatabaseRequest.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/RestoreDatabaseRequestOrBuilder.java
proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/SpannerDatabaseAdminProto.java

google-cla · 2020-11-26T01:30:21Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2021-01-21T02:41:11Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2021-03-15T04:14:43Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2021-03-16T00:00:27Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2021-03-16T06:01:18Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cloud-spanner/src/main/java/com/google/cloud/spanner/BackupInfo.java

google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseInfo.java

google-cloud-spanner/src/main/java/com/google/cloud/spanner/Restore.java

google-cloud-spanner/src/main/java/com/google/cloud/spanner/encryption/EncryptionConfig.java

olavloite · 2021-03-17T08:33:48Z

google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/GapicSpannerRpc.java

+    final Backup.Builder backupBuilder =
+        com.google.spanner.admin.database.v1.Backup.newBuilder()
+            .setDatabase(databaseName)
+            .setExpireTime(backupInfo.getExpireTime().toProto());


I don't think it is guaranteed that backupInfo.getExpireTime() will always be set, so this could cause a NullPointerException.

We shouldn't be able to create a backup without an expire time:

java-spanner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/Backup.java

Lines 64 to 65 in 32fdd60

Preconditions.checkState(

getExpireTime() != null, "Cannot create a backup without an expire time");

I moved these checks into the database client instead (with illegal argument exception, instead of illegal state exceptions), so that we prevent the creation of a Backup without the necessary parameters.

olavloite · 2021-03-17T08:33:48Z

google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/SpannerRpc.java

-   * @param backupId the id of the backup to create.
-   * @param backup the backup to create. The database and expireTime fields of the backup must be
-   *     filled.
+   * @param backupInfo the backup to create. The instance, database and expireTime fields of the


I think we should check for these conditions in the builder for BackupInfo to ensure that they are actually filled. So that would mean that the build() method of the builder should fail if these fields have not been set.

We can not do this in the builder itself, because there are times where the backup can be built without some of the necessary information. For instance:

backup.reload()

backup.delete()

backup.updateExpireTime()

For this reason I moved the checks into the DatabaseAdminClientImpl.createBackup instead.

...anner/src/test/java/com/google/cloud/spanner/encryption/EncryptionConfigProtoMapperTest.java

...e-cloud-spanner/src/test/java/com/google/cloud/spanner/encryption/EncryptionConfigsTest.java

google-cla · 2021-03-17T10:15:19Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2021-03-17T10:15:20Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2021-03-17T10:15:37Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2021-03-17T10:15:37Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2021-03-17T10:16:05Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2021-03-17T10:16:05Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

Co-authored-by: Knut Olav Løite <koloite@gmail.com>

google-cla · 2021-03-17T10:47:30Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2021-03-17T23:25:12Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

thiagotnunes requested review from as code owners Nov 23, 2020

product-auto-label bot added the api: spanner label Nov 23, 2020

google-cla bot added the cla: no label Nov 23, 2020

thiagotnunes added do not merge cla: yes and removed cla: no labels Nov 23, 2020

google-cla bot added cla: no and removed cla: yes labels Nov 23, 2020

yoshi-code-bot reviewed Nov 24, 2020

View changes

thiagotnunes mentioned this pull request Nov 24, 2020

feat: add support for encrypted database #286

Closed

thiagotnunes force-pushed the cmek branch from 9369fe3 to c4ff25a Compare Nov 24, 2020

olavloite approved these changes Nov 25, 2020

View changes

google-cloud-spanner/src/main/java/com/google/cloud/spanner/BackupInfo.java Outdated Show resolved Hide resolved

thiagotnunes force-pushed the cmek branch from fc15196 to e5867c5 Compare Jan 21, 2021

thiagotnunes force-pushed the cmek branch from e5867c5 to 7c979bd Compare Jan 21, 2021

Merge branch 'master' of github.com:googleapis/java-spanner into cmek

4f9db73

chore: adds toString to encryption classes

d78baf3

thiagotnunes requested a review from olavloite Mar 16, 2021

thiagotnunes added cla: yes and removed cla: no labels Mar 17, 2021

olavloite reviewed Mar 17, 2021

View changes

google-cla bot added cla: no and removed cla: yes labels Mar 17, 2021

thiagotnunes and others added 4 commits Mar 17, 2021

docs: updates DatabaseInfo javadoc

2493bcf

Co-authored-by: Knut Olav Løite <koloite@gmail.com>

docs: updates Restore javadocs

d3fe9ab

Co-authored-by: Knut Olav Løite <koloite@gmail.com>

docs: updates DatabaseInfo javadocs

3ff8a89

Co-authored-by: Knut Olav Løite <koloite@gmail.com>

fix: addresses PR comments

acecbfe

thiagotnunes force-pushed the cmek branch from cf9f047 to acecbfe Compare Mar 17, 2021

tests: reformats

09fb850

thiagotnunes added cla: yes and removed cla: no labels Mar 17, 2021

thiagotnunes merged commit 8338116 into master Mar 18, 2021
17 of 19 checks passed

thiagotnunes deleted the cmek branch Mar 18, 2021

release-please bot mentioned this pull request Mar 18, 2021

chore: release 6.0.0 #994

Merged

googleapis / java-spanner Public

feat!: customer-managed encryption keys for Spanner #666

feat!: customer-managed encryption keys for Spanner #666

thiagotnunes commented Nov 23, 2020

generated-files-bot bot commented Nov 23, 2020

google-cla bot commented Nov 23, 2020

generated-files-bot bot commented Nov 23, 2020

google-cla bot commented Nov 23, 2020

codecov bot commented Nov 23, 2020 •

edited

generated-files-bot bot commented Nov 24, 2020

google-cla bot commented Nov 24, 2020

generated-files-bot bot commented Nov 24, 2020

google-cla bot commented Nov 24, 2020

generated-files-bot bot commented Nov 24, 2020

google-cla bot commented Nov 24, 2020

olavloite left a comment

generated-files-bot bot commented Nov 26, 2020

google-cla bot commented Nov 26, 2020

google-cla bot commented Jan 21, 2021

google-cla bot commented Mar 15, 2021

google-cla bot commented Mar 16, 2021

google-cla bot commented Mar 16, 2021

olavloite Mar 17, 2021

thiagotnunes Mar 17, 2021 •

edited

olavloite Mar 17, 2021

thiagotnunes Mar 17, 2021

google-cla bot commented Mar 17, 2021

google-cla bot commented Mar 17, 2021

google-cla bot commented Mar 17, 2021

google-cla bot commented Mar 17, 2021

google-cla bot commented Mar 17, 2021

google-cla bot commented Mar 17, 2021

google-cla bot commented Mar 17, 2021

google-cla bot commented Mar 17, 2021

	Preconditions.checkState(
	getExpireTime() != null, "Cannot create a backup without an expire time");

googleapis / java-spanner Public

feat!: customer-managed encryption keys for Spanner #666

feat!: customer-managed encryption keys for Spanner #666

Conversation

thiagotnunes commented Nov 23, 2020

generated-files-bot bot commented Nov 23, 2020

google-cla bot commented Nov 23, 2020

generated-files-bot bot commented Nov 23, 2020

google-cla bot commented Nov 23, 2020

codecov bot commented Nov 23, 2020 • edited

Codecov Report

generated-files-bot bot commented Nov 24, 2020

google-cla bot commented Nov 24, 2020

generated-files-bot bot commented Nov 24, 2020

google-cla bot commented Nov 24, 2020

generated-files-bot bot commented Nov 24, 2020

google-cla bot commented Nov 24, 2020

olavloite left a comment

generated-files-bot bot commented Nov 26, 2020

google-cla bot commented Nov 26, 2020

google-cla bot commented Jan 21, 2021

google-cla bot commented Mar 15, 2021

google-cla bot commented Mar 16, 2021

google-cla bot commented Mar 16, 2021

olavloite Mar 17, 2021

Choose a reason for hiding this comment

thiagotnunes Mar 17, 2021 • edited

Choose a reason for hiding this comment

olavloite Mar 17, 2021

Choose a reason for hiding this comment

thiagotnunes Mar 17, 2021

Choose a reason for hiding this comment

google-cla bot commented Mar 17, 2021

google-cla bot commented Mar 17, 2021

google-cla bot commented Mar 17, 2021

google-cla bot commented Mar 17, 2021

google-cla bot commented Mar 17, 2021

google-cla bot commented Mar 17, 2021

google-cla bot commented Mar 17, 2021

google-cla bot commented Mar 17, 2021

codecov bot commented Nov 23, 2020 •

edited

thiagotnunes Mar 17, 2021 •

edited