Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: retry admin request limit exceeded error #669

Merged
merged 3 commits into from Nov 30, 2020

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented Nov 24, 2020

Automatically retry requests that fail because the admin requests per seconds limit has been exceeded using an exponential backoff.

Fixes #655 and others

olavloite added 2 commits Nov 24, 2020
Automatically retry requests that fail because the admin requests per seconds
limit has been exceeded using an exponential backoff.

Fixes #655 and others
@olavloite olavloite requested a review from as a code owner Nov 24, 2020
@product-auto-label product-auto-label bot added the api: spanner label Nov 24, 2020
@google-cla google-cla bot added the cla: yes label Nov 24, 2020
@olavloite olavloite added the kokoro:force-run label Nov 24, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Nov 24, 2020
@codecov
Copy link

@codecov codecov bot commented Nov 24, 2020

Codecov Report

Merging #669 (441dcf2) into master (77ed87c) will increase coverage by 0.05%.
The diff coverage is 86.74%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #669      +/-   ##
============================================
+ Coverage     84.06%   84.11%   +0.05%     
- Complexity     2497     2506       +9     
============================================
  Files           141      142       +1     
  Lines         13812    13902      +90     
  Branches       1317     1321       +4     
============================================
+ Hits          11611    11694      +83     
- Misses         1655     1662       +7     
  Partials        546      546              
Impacted Files Coverage Δ Complexity Δ
...m/google/cloud/spanner/spi/v1/GapicSpannerRpc.java 83.22% <86.58%> (+0.59%) 81.00 <1.00> (+1.00)
.../google/cloud/spanner/SpannerExceptionFactory.java 82.47% <86.66%> (+1.98%) 46.00 <3.00> (+7.00)
...anner/AdminRequestsPerMinuteExceededException.java 100.00% <100.00%> (ø) 1.00 <1.00> (?)
.../com/google/cloud/spanner/AbstractReadContext.java 86.76% <0.00%> (+0.61%) 47.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77ed87c...441dcf2. Read the comment docs.

@olavloite olavloite requested a review from thiagotnunes Nov 24, 2020
@thiagotnunes thiagotnunes merged commit 3f9f74a into master Nov 30, 2020
21 checks passed
@thiagotnunes thiagotnunes deleted the retry-admin-request-exceeded branch Nov 30, 2020
@thiagotnunes thiagotnunes mentioned this pull request Dec 1, 2020
thiagotnunes pushed a commit that referenced this issue May 6, 2021
* feat: retry admin request limit exceeded error

Automatically retry requests that fail because the admin requests per seconds
limit has been exceeded using an exponential backoff.

Fixes #655 and others

* fix: remove unused variable

* fix: extract strings to constants
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants