feat: allow lenient mode for connection properties #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some applications automatically add additional properties to connection strings that are unknown to the Spanner Connection API (and thereby also the Spanner JDBC driver). This causes the connection attempt to fail. This change allows a user to specify 'lenient' mode where unknown properties only generate a warning instead of an error. Fixes dropwizard/dropwizard#3461 Fixes googleapis/google-cloud-java#6671 Fixes googleapis/java-spanner-jdbc#283
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: spanner
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Codecov Report
@@ Coverage Diff @@
## master #671 +/- ##
============================================
+ Coverage 84.06% 84.10% +0.03%
- Complexity 2497 2502 +5
============================================
Files 141 141
Lines 13812 13821 +9
Branches 1317 1319 +2
============================================
+ Hits 11611 11624 +13
+ Misses 1655 1652 -3
+ Partials 546 545 -1
Continue to review full report at Codecov.
|
thiagotnunes
approved these changes
Nov 26, 2020
thiagotnunes
pushed a commit
that referenced
this issue
May 6, 2021
* feat: allow lenient mode for connection properties Some applications automatically add additional properties to connection strings that are unknown to the Spanner Connection API (and thereby also the Spanner JDBC driver). This causes the connection attempt to fail. This change allows a user to specify 'lenient' mode where unknown properties only generate a warning instead of an error. Fixes dropwizard/dropwizard#3461 Fixes googleapis/google-cloud-java#6671 Fixes googleapis/java-spanner-jdbc#283 * fix: add credentials to prevent tests from trying to use env credentials
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Some applications automatically add additional properties to connection strings that are unknown to the Spanner Connection API (and thereby also the Spanner JDBC driver). This causes the connection attempt to fail. This change allows a user to specify 'lenient' mode where unknown properties only generate a warning instead of an error.
Needed for dropwizard/dropwizard#3461
Needed for googleapis/google-cloud-java#6671
Needed for googleapis/java-spanner-jdbc#283