Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: homogenize region tags #752

Merged

Conversation

Strykrol
Copy link
Contributor

@Strykrol Strykrol commented Dec 15, 2020

These samples' region tags slightly differ from identical snippets in different languages. The following is the remedy:

  1. Merge this PR to fix GitHub source (keep old tag for now)
  2. Fix doc code includes to represent the better region tag
  3. Submit a second PR to clean-up redundant region tag wrapping

@Strykrol Strykrol requested a review from as a code owner Dec 15, 2020
@Strykrol Strykrol requested a review from Dec 15, 2020
@google-cla google-cla bot added the cla: yes label Dec 15, 2020
@product-auto-label product-auto-label bot added the api: spanner label Dec 15, 2020
@snippet-bot
Copy link

@snippet-bot snippet-bot bot commented Dec 15, 2020

Here is the summary of changes.

You added 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@codecov
Copy link

@codecov codecov bot commented Dec 15, 2020

Codecov Report

Merging #752 (7fce014) into master (daef458) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #752      +/-   ##
============================================
- Coverage     85.15%   85.15%   -0.01%     
+ Complexity     2564     2563       -1     
============================================
  Files           142      142              
  Lines         13952    13960       +8     
  Branches       1331     1331              
============================================
+ Hits          11881    11887       +6     
- Misses         1512     1514       +2     
  Partials        559      559              
Impacted Files Coverage Δ Complexity Δ
.../google/cloud/spanner/SpannerExceptionFactory.java 82.47% <0.00%> (-2.07%) 46.00% <0.00%> (-1.00%)
...m/google/cloud/spanner/spi/v1/GapicSpannerRpc.java 83.39% <0.00%> (+0.17%) 81.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daef458...7fce014. Read the comment docs.

@skuruppu skuruppu added kokoro:force-run automerge labels Dec 15, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Dec 15, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 2b3775a into googleapis:master Dec 15, 2020
21 of 22 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge label Dec 15, 2020
thiagotnunes pushed a commit that referenced this issue May 6, 2021
These samples' region tags slightly differ from identical snippets in different languages. The following is the remedy:

1. Merge this PR to fix GitHub source (keep old tag for now)
2. Fix doc code includes to represent the better region tag
3. Submit a second PR to clean-up redundant region tag wrapping
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants