Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: documents resume on update database ddl #767

Merged

Conversation

thiagotnunes
Copy link
Contributor

@thiagotnunes thiagotnunes commented Jan 5, 2021

Instead of throwing an ALREADY_EXISTS error on the update database ddl operation, we resume the original operation. This is necessary, because the update database ddl is retryable. Because of this, we don't want to confuse the caller by bubbling up an ALREADY_EXISTS error on a retry, even though they used a non-existing operation id.

Instead of throwing an ALREADY_EXISTS error on the update database ddl
operation, we resume the original operation. This is necessary, because
the update database ddl is retryable. Because of this, we don't want to
confuse the caller by bubbling up an ALREADY_EXISTS error on a retry,
even though they used a non-existing operation id.
@thiagotnunes thiagotnunes requested a review from as a code owner Jan 5, 2021
@product-auto-label product-auto-label bot added the api: spanner label Jan 5, 2021
@google-cla google-cla bot added the cla: yes label Jan 5, 2021
@codecov
Copy link

@codecov codecov bot commented Jan 5, 2021

Codecov Report

Merging #767 (5fda169) into master (90ad9d6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #767   +/-   ##
=========================================
  Coverage     85.00%   85.00%           
  Complexity     2562     2562           
=========================================
  Files           143      143           
  Lines         14007    14007           
  Branches       1338     1338           
=========================================
  Hits          11906    11906           
  Misses         1538     1538           
  Partials        563      563           
Impacted Files Coverage Δ Complexity Δ
...m/google/cloud/spanner/spi/v1/GapicSpannerRpc.java 81.35% <ø> (ø) 81.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90ad9d6...5fda169. Read the comment docs.

@thiagotnunes thiagotnunes requested review from olavloite and skuruppu Jan 5, 2021
@thiagotnunes thiagotnunes merged commit aeb255d into googleapis:master Jan 5, 2021
19 checks passed
@thiagotnunes thiagotnunes deleted the document-update-database-ddl branch Jan 5, 2021
thiagotnunes added a commit that referenced this issue May 6, 2021
Instead of throwing an ALREADY_EXISTS error on the update database ddl
operation, we resume the original operation. This is necessary, because
the update database ddl is retryable. Because of this, we don't want to
confuse the caller by bubbling up an ALREADY_EXISTS error on a retry,
even though they used a non-existing operation id.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants