Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: attempt DirectPath by default #770

Merged
merged 6 commits into from Jan 6, 2021

Conversation

mohanli-ml
Copy link
Contributor

@mohanli-ml mohanli-ml commented Jan 5, 2021

Update client to attempt DirectPath by default.

Note that it doesn't mean that after this change client will just use DirectPath, but will call the DirectPath codepath by default.

The actually enablement of DirectPath is controlled by service owner via ACL config. For now, after this change, although all users will attempt DirectPath, but they will all just fallback to the original CFE path.

For testing, we still use the DP test endpoint aa423245250f2bbf.sandbox.googleapis.com to override the default endpoint.

@mohanli-ml mohanli-ml requested a review from as a code owner Jan 5, 2021
@product-auto-label product-auto-label bot added the api: spanner label Jan 5, 2021
@google-cla google-cla bot added the cla: yes label Jan 5, 2021
@codecov
Copy link

@codecov codecov bot commented Jan 6, 2021

Codecov Report

Merging #770 (6329b45) into master (90ad9d6) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #770      +/-   ##
============================================
+ Coverage     85.00%   85.01%   +0.01%     
+ Complexity     2562     2560       -2     
============================================
  Files           143      143              
  Lines         14007    14005       -2     
  Branches       1338     1337       -1     
============================================
  Hits          11906    11906              
+ Misses         1538     1537       -1     
+ Partials        563      562       -1     
Impacted Files Coverage Δ Complexity Δ
...m/google/cloud/spanner/spi/v1/GapicSpannerRpc.java 81.55% <100.00%> (+0.20%) 80.00 <0.00> (-1.00) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90ad9d6...6329b45. Read the comment docs.

@thiagotnunes thiagotnunes changed the title feat: attemp DirectPath by default feat: attempt DirectPath by default Jan 6, 2021
Copy link
Contributor

@thiagotnunes thiagotnunes left a comment

LGTM

@thiagotnunes thiagotnunes merged commit dc02244 into googleapis:master Jan 6, 2021
19 checks passed
thiagotnunes pushed a commit that referenced this issue May 6, 2021
* chore: add DirectPath fallback integration test

* feat: attemp DirectPath by default

* feat: attemp DirectPath by default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants