feat: attempt DirectPath by default #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: spanner
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #770 +/- ##
============================================
+ Coverage 85.00% 85.01% +0.01%
+ Complexity 2562 2560 -2
============================================
Files 143 143
Lines 14007 14005 -2
Branches 1338 1337 -1
============================================
Hits 11906 11906
+ Misses 1538 1537 -1
+ Partials 563 562 -1
Continue to review full report at Codecov.
|
thiagotnunes
changed the title
thiagotnunes
pushed a commit
that referenced
this issue
May 6, 2021
* chore: add DirectPath fallback integration test * feat: attemp DirectPath by default * feat: attemp DirectPath by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Update client to attempt DirectPath by default.
Note that it doesn't mean that after this change client will just use DirectPath, but will call the DirectPath codepath by default.
The actually enablement of DirectPath is controlled by service owner via ACL config. For now, after this change, although all users will attempt DirectPath, but they will all just fallback to the original CFE path.
For testing, we still use the DP test endpoint aa423245250f2bbf.sandbox.googleapis.com to override the default endpoint.