Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set up DirectPath e2e tests correctly #780

Merged
merged 6 commits into from Jan 7, 2021

Conversation

mohanli-ml
Copy link
Contributor

@mohanli-ml mohanli-ml commented Jan 7, 2021

In #770 we make the client to attempt DirectPath by default using the default spanner endpoint spanner.googleapis.com. However, currently DirectPath tests still need to use a custom endpoint aa423245250f2bbf.sandbox.googleapis.com, so we need to set it to a customChannelProvider, which will override the defaultChannelProvider in https://github.com/googleapis/java-spanner/blob/master/google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/GapicSpannerRpc.java#L336. As a result, DirectPath tests can not be run properly. This PR fixes this problem by setting up the customChannelProvider properly.

@mohanli-ml mohanli-ml requested a review from as a code owner Jan 7, 2021
@product-auto-label product-auto-label bot added the api: spanner label Jan 7, 2021
@google-cla google-cla bot added the cla: yes label Jan 7, 2021
@codecov
Copy link

@codecov codecov bot commented Jan 7, 2021

Codecov Report

Merging #780 (b750278) into master (beeac09) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #780      +/-   ##
============================================
+ Coverage     85.01%   85.05%   +0.04%     
- Complexity     2561     2564       +3     
============================================
  Files           143      143              
  Lines         14005    14005              
  Branches       1337     1337              
============================================
+ Hits          11906    11912       +6     
+ Misses         1537     1532       -5     
+ Partials        562      561       -1     
Impacted Files Coverage Δ Complexity Δ
.../google/cloud/spanner/SpannerExceptionFactory.java 83.50% <0.00%> (+1.03%) 47.00% <0.00%> (+1.00%)
...m/google/cloud/spanner/connection/FailedQuery.java 82.75% <0.00%> (+6.89%) 3.00% <0.00%> (+1.00%)
...r/AbortedDueToConcurrentModificationException.java 85.71% <0.00%> (+42.85%) 2.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update beeac09...b750278. Read the comment docs.

@thiagotnunes thiagotnunes merged commit 9b94c6e into googleapis:master Jan 7, 2021
19 checks passed
thiagotnunes pushed a commit that referenced this issue May 6, 2021
* chore: add DirectPath fallback integration test

* fix: Set up DirectPath e2e tests correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants