Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow session pool settings in connection url #821

Merged
merged 2 commits into from Jan 31, 2021

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented Jan 26, 2021

Allows min/max sessions for the backing SessionPool to be specified in the connection URL.

Towards googleapis/java-spanner-jdbc#334

@olavloite olavloite requested a review from thiagotnunes Jan 26, 2021
@olavloite olavloite requested a review from as a code owner Jan 26, 2021
@google-cla google-cla bot added the cla: yes label Jan 26, 2021
@product-auto-label product-auto-label bot added the api: spanner label Jan 26, 2021
@codecov
Copy link

@codecov codecov bot commented Jan 30, 2021

Codecov Report

Merging #821 (4bdabb6) into master (2f1450c) will decrease coverage by 0.07%.
The diff coverage is 59.25%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #821      +/-   ##
============================================
- Coverage     85.05%   84.98%   -0.08%     
- Complexity     2564     2580      +16     
============================================
  Files           143      143              
  Lines         14062    14132      +70     
  Branches       1348     1368      +20     
============================================
+ Hits          11961    12010      +49     
- Misses         1539     1550      +11     
- Partials        562      572      +10     
Impacted Files Coverage Δ Complexity Δ
...a/com/google/cloud/spanner/SessionPoolOptions.java 70.31% <30.95%> (-19.35%) 19.00 <3.00> (+3.00) ⬇️
...le/cloud/spanner/connection/ConnectionOptions.java 89.13% <88.57%> (+1.87%) 77.00 <8.00> (+12.00)
...m/google/cloud/spanner/connection/SpannerPool.java 86.88% <100.00%> (+2.44%) 31.00 <0.00> (ø)
...ain/java/com/google/cloud/spanner/SessionPool.java 89.24% <0.00%> (+0.19%) 73.00% <0.00%> (ø%)
...n/java/com/google/cloud/spanner/SessionClient.java 92.06% <0.00%> (+0.79%) 16.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f1450c...075683c. Read the comment docs.

@olavloite olavloite added the kokoro:force-run label Jan 30, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jan 30, 2021
@thiagotnunes thiagotnunes merged commit e1e9152 into master Jan 31, 2021
17 checks passed
@thiagotnunes thiagotnunes deleted the connection-sessionpool-options branch Jan 31, 2021
thiagotnunes pushed a commit that referenced this issue May 6, 2021
* feat: allow session pool settings in connection url

* fix: use NoCredentials in test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants