Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make compiled statements immutable #843

Merged
merged 1 commit into from Feb 2, 2021
Merged

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented Feb 1, 2021

Compiled client side statements should be immutable as they are only imported and compiled once.

@olavloite olavloite added the type: cleanup label Feb 1, 2021
@olavloite olavloite requested a review from thiagotnunes Feb 1, 2021
@olavloite olavloite requested a review from as a code owner Feb 1, 2021
@product-auto-label product-auto-label bot added the api: spanner label Feb 1, 2021
@google-cla google-cla bot added the cla: yes label Feb 1, 2021
@codecov
Copy link

@codecov codecov bot commented Feb 1, 2021

Codecov Report

Merging #843 (b857ff5) into master (61ea2b9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #843   +/-   ##
=========================================
  Coverage     85.04%   85.04%           
+ Complexity     2585     2583    -2     
=========================================
  Files           143      143           
  Lines         14145    14146    +1     
  Branches       1369     1369           
=========================================
+ Hits          12030    12031    +1     
  Misses         1542     1542           
  Partials        573      573           
Impacted Files Coverage Δ Complexity Δ
...ud/spanner/connection/ClientSideStatementImpl.java 50.00% <100.00%> (+1.11%) 9.00 <0.00> (ø)
...connection/ClientSideStatementNoParamExecutor.java 71.42% <100.00%> (ø) 2.00 <1.00> (-1.00)
...ner/connection/ClientSideStatementSetExecutor.java 85.36% <100.00%> (ø) 5.00 <1.00> (-1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61ea2b9...be7cdfd. Read the comment docs.

@thiagotnunes thiagotnunes merged commit 118d1b3 into master Feb 2, 2021
17 checks passed
@thiagotnunes thiagotnunes deleted the statements-immutable branch Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes type: cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants