Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: drops support of Java 7 #946

Merged
merged 3 commits into from Mar 18, 2021
Merged

feat!: drops support of Java 7 #946

merged 3 commits into from Mar 18, 2021

Conversation

thiagotnunes
Copy link
Contributor

@thiagotnunes thiagotnunes commented Mar 11, 2021

From the next major release we will be only supporting Java 8+.

From the next major release we will be only supporting Java 8+
@thiagotnunes thiagotnunes requested review from as code owners Mar 11, 2021
@generated-files-bot
Copy link

@generated-files-bot generated-files-bot bot commented Mar 11, 2021

Warning: This pull request is touching the following templated files:

  • .github/workflows/ci.yaml
  • .kokoro/nightly/java7.cfg
  • .kokoro/presubmit/java7.cfg
  • CONTRIBUTING.md

@google-cla google-cla bot added the cla: yes label Mar 11, 2021
@product-auto-label product-auto-label bot added the api: spanner label Mar 11, 2021
@thiagotnunes thiagotnunes added the do not merge label Mar 11, 2021
@thiagotnunes
Copy link
Contributor Author

@thiagotnunes thiagotnunes commented Mar 11, 2021

This should only be merged when we are planning the next major bump (for CMEK, #666).

@codecov
Copy link

@codecov codecov bot commented Mar 18, 2021

Codecov Report

Merging #946 (a3bece7) into master (32fdd60) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #946      +/-   ##
============================================
- Coverage     85.24%   85.21%   -0.03%     
+ Complexity     2660     2570      -90     
============================================
  Files           146      146              
  Lines         14404    14159     -245     
  Branches       1395     1313      -82     
============================================
- Hits          12278    12066     -212     
- Misses         1542     1544       +2     
+ Partials        584      549      -35     
Impacted Files Coverage Δ Complexity Δ
...a/com/google/cloud/spanner/DatabaseClientImpl.java 76.69% <0.00%> (-7.77%) 21.00% <0.00%> (ø%)
.../cloud/spanner/spi/v1/SpannerErrorInterceptor.java 52.94% <0.00%> (-7.06%) 3.00% <0.00%> (ø%)
...ud/spanner/connection/ClientSideStatementImpl.java 48.88% <0.00%> (-1.12%) 9.00% <0.00%> (ø%)
...oogle/cloud/spanner/PartitionedDmlTransaction.java 82.02% <0.00%> (-0.59%) 14.00% <0.00%> (-1.00%)
...ain/java/com/google/cloud/spanner/SessionPool.java 88.73% <0.00%> (-0.53%) 71.00% <0.00%> (-2.00%)
...m/google/cloud/spanner/spi/v1/GapicSpannerRpc.java 81.41% <0.00%> (-0.48%) 71.00% <0.00%> (-12.00%)
...e/cloud/spanner/connection/CredentialsService.java 90.00% <0.00%> (-0.48%) 8.00% <0.00%> (ø%)
...m/google/cloud/spanner/TransactionManagerImpl.java 87.03% <0.00%> (-0.47%) 21.00% <0.00%> (ø%)
.../com/google/cloud/spanner/AbstractReadContext.java 86.54% <0.00%> (-0.33%) 42.00% <0.00%> (-6.00%)
.../admin/instance/v1/stub/GrpcInstanceAdminStub.java 96.94% <0.00%> (-0.24%) 21.00% <0.00%> (-1.00%)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32fdd60...a3bece7. Read the comment docs.

@thiagotnunes thiagotnunes removed the do not merge label Mar 18, 2021
@thiagotnunes thiagotnunes merged commit 7af1951 into master Mar 18, 2021
19 of 20 checks passed
@thiagotnunes thiagotnunes deleted the java-8 branch Mar 18, 2021
@release-please release-please bot mentioned this pull request Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants