Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: never use credentials in combination with plain text #98

Merged
merged 1 commit into from Mar 13, 2020

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented Mar 12, 2020

Credentials should never be used in combination with plain text communication. Setting an emulator host should therefore also automatically override any credentials that may have been set.

@olavloite olavloite requested review from hengfengli and skuruppu Mar 12, 2020
@googlebot googlebot added the cla: yes label Mar 12, 2020
Copy link
Contributor

@hengfengli hengfengli left a comment

Thanks for fixing this, 👍

@skuruppu skuruppu merged commit 7eb8d49 into master Mar 13, 2020
13 checks passed
@skuruppu skuruppu deleted the no-credentials-with-plain-text branch Mar 13, 2020
gcf-merge-on-green bot pushed a commit that referenced this issue Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants