Skip to content
This repository was archived by the owner on Dec 15, 2023. It is now read-only.

docs(samples): refactors the export-to-gcs sample - #737

Merged
lesv merged 11 commits into
googleapis:mainfrom
b-loved-dreamer:refactorexporttogcs
Dec 2, 2021
Merged

lesv merged 11 commits into
googleapis:mainfrom
b-loved-dreamer:refactorexporttogcs

Conversation

@b-loved-dreamer

Copy link
Copy Markdown
Contributor

this PR attempts to keep consistency among the NodeJS, Python and Java versions of the export-to-gcs samples

@b-loved-dreamer
b-loved-dreamer requested a review from a team November 25, 2021 00:03
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 25, 2021
@product-auto-label product-auto-label Bot added api: speech Issues related to the googleapis/java-speech API. samples Issues that are directly related to samples. labels Nov 25, 2021
@generated-files-bot

generated-files-bot Bot commented Nov 25, 2021 •

Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

  • samples/snapshot/pom.xml
  • samples/snippets/pom.xml

@lesv lesv added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 29, 2021
@lesv

lesv commented Nov 29, 2021

Copy link
Copy Markdown
Contributor

@b-loved-dreamer There is a warning that your trying to update the pom.xml file. That is templated which means that your change is likely to get lost. You will find that GSON is already present and fairly easy to use. (Instead of what your trying to update.) Feel free to reach out to me or Neenu tomorrow.

@lesv lesv removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 30, 2021
@b-loved-dreamer

Copy link
Copy Markdown
Contributor Author

@lesv - thanks for your help.

@lesv

lesv commented Dec 2, 2021

Copy link
Copy Markdown
Contributor

@b-loved-dreamer You can safely ignore the problem w/ GraalVM. If it's ok to merge - I'd be happy to do it for you.

@lesv
lesv merged commit 9714f7b into googleapis:main Dec 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: speech Issues related to the googleapis/java-speech API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants