Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(samples): refactors the export-to-gcs sample #737

Merged
merged 11 commits into from Dec 2, 2021

Conversation

b-loved-dreamer
Copy link
Contributor

@b-loved-dreamer b-loved-dreamer commented Nov 25, 2021

this PR attempts to keep consistency among the NodeJS, Python and Java versions of the export-to-gcs samples

@b-loved-dreamer b-loved-dreamer requested a review from as a code owner Nov 25, 2021
@google-cla google-cla bot added the cla: yes label Nov 25, 2021
@product-auto-label product-auto-label bot added api: speech samples labels Nov 25, 2021
@generated-files-bot
Copy link

@generated-files-bot generated-files-bot bot commented Nov 25, 2021

Warning: This pull request is touching the following templated files:

  • samples/snapshot/pom.xml
  • samples/snippets/pom.xml

@lesv lesv added the do not merge label Nov 29, 2021
@lesv
Copy link
Contributor

@lesv lesv commented Nov 29, 2021

@b-loved-dreamer There is a warning that your trying to update the pom.xml file. That is templated which means that your change is likely to get lost. You will find that GSON is already present and fairly easy to use. (Instead of what your trying to update.) Feel free to reach out to me or Neenu tomorrow.

lesv
lesv approved these changes Nov 30, 2021
@lesv lesv removed the do not merge label Nov 30, 2021
@b-loved-dreamer
Copy link
Contributor Author

@b-loved-dreamer b-loved-dreamer commented Dec 2, 2021

@lesv - thanks for your help.

@lesv
Copy link
Contributor

@lesv lesv commented Dec 2, 2021

@b-loved-dreamer You can safely ignore the problem w/ GraalVM. If it's ok to merge - I'd be happy to do it for you.

@lesv lesv merged commit 9714f7b into googleapis:main Dec 2, 2021
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: speech cla: yes samples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants