Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set update time in LocalStorageHelper/FakeStorageRpc #173

Closed
hosainnet opened this issue Jul 19, 2020 · 2 comments · Fixed by #174
Closed

Set update time in LocalStorageHelper/FakeStorageRpc #173

hosainnet opened this issue Jul 19, 2020 · 2 comments · Fixed by #174
Assignees
Labels
api: storage priority: p2 🚨 type: bug

Comments

@hosainnet
Copy link
Contributor

@hosainnet hosainnet commented Jul 19, 2020

Is your feature request related to a problem? Please describe.

When trying to test any time-based/process once filters (such as https://github.com/spring-cloud/spring-cloud-gcp/blob/master/spring-cloud-gcp-storage/src/main/java/org/springframework/cloud/gcp/storage/integration/filters/GcsPersistentAcceptOnceFileListFilter.java#L31) via FakeStorageRpc it doesn't work as expected (NPE/fixed time is set)

*Describe the solution you'd like

Any time we write a blob, we need update time to be set on the storage object

Describe alternatives you've considered

Not using those filters in tests, but that means our test is not realstic due to different behaviours in test/main code

Additional context
None

@product-auto-label product-auto-label bot added the api: storage label Jul 19, 2020
@yoshi-automation yoshi-automation added the triage me label Jul 20, 2020
@hosainnet
Copy link
Contributor Author

@hosainnet hosainnet commented Jul 20, 2020

PR: #174

@yoshi-automation yoshi-automation added the 🚨 label Jul 24, 2020
@frankyn frankyn added priority: p2 type: bug type: feature request and removed 🚨 triage me type: bug type: feature request labels Jul 28, 2020
@hosainnet
Copy link
Contributor Author

@hosainnet hosainnet commented Aug 4, 2020

@frankyn @JesseLovelace any update on this? I already I have a PR #174
Many thanks :)

@yoshi-automation yoshi-automation added 🚨 and removed 🚨 labels Nov 2, 2020
@yoshi-automation yoshi-automation added the 🚨 label Jan 15, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Jan 27, 2021
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/java-storage-nio/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [x] Ensure the tests and linter pass
- [x] Code coverage does not decrease (if any source code was changed)
- [x] Appropriate docs were updated (if necessary)

Fixes #173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage priority: p2 🚨 type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants