Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update FakeStorageRpc to extend StorageRpcTestBase #135

Merged
merged 5 commits into from Jun 17, 2020

Conversation

dmitry-fa
Copy link
Contributor

@dmitry-fa dmitry-fa commented Jun 15, 2020

Fixes #124

@googlebot googlebot added the cla: yes label Jun 15, 2020
@codecov
Copy link

@codecov codecov bot commented Jun 15, 2020

Codecov Report

Merging #135 into master will increase coverage by 1.32%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #135      +/-   ##
============================================
+ Coverage     70.11%   71.43%   +1.32%     
  Complexity      483      483              
============================================
  Files            29       29              
  Lines          1673     1642      -31     
  Branches        265      265              
============================================
  Hits           1173     1173              
+ Misses          376      345      -31     
  Partials        124      124              
Impacted Files Coverage Δ Complexity Δ
...ud/storage/contrib/nio/testing/FakeStorageRpc.java 67.94% <ø> (+8.77%) 43.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68508ce...0565ce1. Read the comment docs.

@dmitry-fa dmitry-fa added the kokoro:force-run label Jun 15, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jun 15, 2020
@dmitry-fa
Copy link
Contributor Author

@dmitry-fa dmitry-fa commented Jun 15, 2020

@frankyn, @chingor13, @JesseLovelace
I added a new class in java-storage 1.109.0 and try to use this class in java-storage-nio.
Everything is fine, but linkage-monitor check fails: the new class is not found. Looks like the linkage-monitor refers to an outdated version of java-storage.
Could you give me any advice on how to handle this?

@frankyn
Copy link
Member

@frankyn frankyn commented Jun 15, 2020

Hi @dmitry-fa, thanks for putting this together. I merged the updated version of Java-storage. Please merge master into your branch.

@frankyn
Copy link
Member

@frankyn frankyn commented Jun 16, 2020

@kolea2 could you help release a new version of libraries-bom with updated versions of google-cloud-storage and google-cloud-nio? It will help unblock this PR.

@dmitry-fa dmitry-fa added the kokoro:force-run label Jun 17, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jun 17, 2020
@frankyn
Copy link
Member

@frankyn frankyn commented Jun 17, 2020

Merge master @dmitry-fa

@frankyn frankyn merged commit 3233a4c into googleapis:master Jun 17, 2020
14 checks passed
@frankyn frankyn added the release-please:force-run label Jun 17, 2020
@release-please release-please bot removed the release-please:force-run label Jun 17, 2020
@chingor13 chingor13 added the fix label Jun 17, 2020
frankyn added a commit that referenced this issue Jun 18, 2020
gcf-merge-on-green bot pushed a commit that referenced this issue Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants