Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set storage update time in FakeStorageRpc #174

Conversation

hosainnet
Copy link
Contributor

@hosainnet hosainnet commented Jul 19, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #173

@google-cla
Copy link

@google-cla google-cla bot commented Jul 19, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jul 19, 2020
@hosainnet
Copy link
Contributor Author

@hosainnet hosainnet commented Jul 19, 2020

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Jul 19, 2020
@codecov
Copy link

@codecov codecov bot commented Jul 19, 2020

Codecov Report

Merging #174 (8ce0ccd) into master (4e7bac1) will increase coverage by 0.50%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #174      +/-   ##
============================================
+ Coverage     71.71%   72.21%   +0.50%     
- Complexity      495      499       +4     
============================================
  Files            29       29              
  Lines          1658     1663       +5     
  Branches        268      268              
============================================
+ Hits           1189     1201      +12     
+ Misses          344      336       -8     
- Partials        125      126       +1     
Impacted Files Coverage Δ Complexity Δ
...ud/storage/contrib/nio/testing/FakeStorageRpc.java 71.42% <100.00%> (+3.97%) 47.00 <2.00> (+4.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e7bac1...8ce0ccd. Read the comment docs.

@hosainnet hosainnet force-pushed the fake-storage-rpc-set-update-time branch from bab6f0e to a9493a4 Compare Jul 19, 2020
@hosainnet
Copy link
Contributor Author

@hosainnet hosainnet commented Jul 21, 2020

hosainnet added 2 commits Aug 4, 2020
# Conflicts:
#	google-cloud-nio/src/main/java/com/google/cloud/storage/contrib/nio/testing/FakeStorageRpc.java
@product-auto-label product-auto-label bot added the api: storage label Aug 21, 2020
@frankyn frankyn requested a review from JesseLovelace Jan 19, 2021
@frankyn frankyn changed the title Set storage update time in FakeStorageRpc fix: Set storage update time in FakeStorageRpc Jan 27, 2021
@frankyn frankyn added the kokoro:force-run label Jan 27, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jan 27, 2021
@frankyn frankyn added the automerge label Jan 27, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 1328de4 into googleapis:master Jan 27, 2021
17 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge label Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants