fix: move autovalue to annotation processor path

[elharo]

@suraj-qlogic @suztomo

fixes #178

[elharo]

2020-07-27T15:15:25.6293721Z [ERROR] com.google.cloud.storage.contrib.nio.CloudStorageFileAttributesTest.testAcl Time elapsed: 0.451 s <<< ERROR!
2020-07-27T15:15:25.6302204Z java.nio.file.FileSystemNotFoundException: Provider "gs" not installed
2020-07-27T15:15:25.6310326Z at com.google.cloud.storage.contrib.nio.CloudStorageFileAttributesTest.before(CloudStorageFileAttributesTest.java:49)
2020-07-27T15:15:25.6311534Z

[elharo]

Just maybe relevant:

[WARNING] *****************************************************************
[WARNING] * Your build is requesting parallel execution, but project *
[WARNING] * contains the following plugin(s) that have goals not marked *
[WARNING] * as @threadsafe to support parallel building. *
[WARNING] * While this /may/ work fine, please look for plugin updates *
[WARNING] * and/or request plugins be made thread-safe. *
[WARNING] * If reporting an issue, report it against the plugin in *
[WARNING] * question, not against maven-core *
[WARNING] *****************************************************************
[WARNING] The following plugins are not marked @threadsafe in Storage Parent:
[WARNING] org.codehaus.mojo:clirr-maven-plugin:2.8
[WARNING] Enable debug to see more precisely which goals are not marked @threadsafe.
[WARNING] ***

[elharo]

tests are running in parallel and are not using random paths:

  @Before
  public void before() {
    CloudStorageFileSystemProvider.setStorageOptions(LocalStorageHelper.getOptions());
    path = Paths.get(URI.create("gs://bucket/randompath"));
    dir = Paths.get(URI.create("gs://bucket/randompath/"));
  }

[generated-files-bot]

Warning: This pull request is touching the following templated files:

• .kokoro/build.sh

[frankyn]

This issue might be related to recent failures. Not quite sure what's going on though as I'm not able to repro this issue locally.

[codecov]

Codecov Report

Merging #179 (d153920) into master (1328de4) will increase coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #179      +/-   ##
============================================
+ Coverage     72.21%   72.29%   +0.07%     
  Complexity      500      500              
============================================
  Files            29       29              
  Lines          1663     1664       +1     
  Branches        268      277       +9     
============================================
+ Hits           1201     1203       +2     
  Misses          336      336              
+ Partials        126      125       -1     

Impacted Files	Coverage Δ	Complexity Δ
...ge/contrib/nio/CloudStorageFileSystemProvider.java	63.23% <ø> (+0.32%)	76.00 <0.00> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1328de4...375ff4d. Read the comment docs.

[frankyn]

Woot, looks like things are passing now. Pending review from @BenWhitehead when he's back in the office tomorrow.

[elharo]

1.7.4 is out now

[elharo]

com.google.api.client.http.HttpResponseException:
403 Forbidden

POST https://storage.googleapis.com:443/upload/storage/v1/b/bucket/o?uploadType=resumable&name=randompath
{
  "error": {
    "code": 403,
    "message": "it-service-account@gcloud-devel.iam.gserviceaccount.com does not have storage.objects.create access to bucket/randompath.",
    "errors": [
      {
        "message": "it-service-account@gcloud-devel.iam.gserviceaccount.com does not have storage.objects.create access to bucket/randompath.",
        "domain": "global",
        "reason": "forbidden"
      }
    ]
  }

[frankyn]

Will continue debugging. This looks related to the open failures that exist right now.

[frankyn]

@elharo I found that auto-service was missing in plugins which helped generate the META-INF/ file that's expected.

If it looks good to you, can we merge this in?

[BenWhitehead]

Shared config has had auto-value support for some time.

We should be able to remove auto-value and auto-service and use the config from shared config.

See https://github.com/googleapis/java-firestore/pull/221/files for an example of it being used in Firestore.

[elharo]

@BenWhitehead PTAL. The commit history is becoming convoluted, but I think this is now what you asked for,

[elharo]

MockitoErrors in Java 7. CloudStorageLateInitializationTest.before:41 » UnsupportedClassVersion org/moc...

[frankyn]

Stuck on:

[INFO] <<< maven-dependency-plugin:3.1.2:analyze (default-cli) < test-compile @ google-cloud-nio <<<
[INFO] 
[INFO] 
[INFO] --- maven-dependency-plugin:3.1.2:analyze (default-cli) @ google-cloud-nio ---
Warning:  Used undeclared dependencies found:
Warning:     com.google.auto.value:auto-value-annotations:jar:1.7.4:compile

Thanks @elharo!

[frankyn]

Kokoro integrations failed again. I think it might be a flake and not sure how to reinforce without doing a retry of the tests.

[frankyn]

Chatting with @BenWhitehead, the kokoro build change to retry tests will be removed by autosynth...

[frankyn]

We will merge this PR once jobs pass and will follow-up with another solution provided by @BenWhitehead for flaky integration tests to separate tasks.
I'm still on the hook as part of On Duty next week.