Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make repo releasable, add parent pom #6

Merged
merged 3 commits into from Jan 13, 2020
Merged

feat: make repo releasable, add parent pom #6

merged 3 commits into from Jan 13, 2020

Conversation

chingor13
Copy link
Collaborator

@chingor13 chingor13 commented Jan 13, 2020

Creates a parent pom, adds our common templates and makes this repository releasable.

Note that the integration test is failing. I believe these tests would have been failing in the original google-cloud-java repo, but the integration tests for Storage NIO were not running. Those failing tests will not work given that we're running our tests on GCE instances and the default project will be found.

@googlebot googlebot added the cla: yes label Jan 13, 2020
@codecov
Copy link

@codecov codecov bot commented Jan 13, 2020

Codecov Report

No coverage uploaded for pull request base (master@db554de). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #6   +/-   ##
=========================================
  Coverage          ?   70.11%           
  Complexity        ?      483           
=========================================
  Files             ?       29           
  Lines             ?     1673           
  Branches          ?      265           
=========================================
  Hits              ?     1173           
  Misses            ?      376           
  Partials          ?      124

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db554de...fc2e7bb. Read the comment docs.

@chingor13 chingor13 marked this pull request as ready for review Jan 13, 2020
@chingor13 chingor13 requested a review from Jan 13, 2020
@chingor13
Copy link
Collaborator Author

@chingor13 chingor13 commented Jan 13, 2020

Note that the integration test is failing. I believe these tests would have been failing in the original google-cloud-java repo, but the integration tests for Storage NIO were not running. Those failing tests will not work given that we're running our tests on GCE instances and the default project will be found.

We can fix these tests separately from this PR.

@chingor13 chingor13 merged commit 6bca496 into master Jan 13, 2020
12 of 13 checks passed
@chingor13 chingor13 deleted the releasable branch Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants