This repository was archived by the owner on Apr 2, 2026. It is now read-only.
Conversation
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #6 +/- ##
=========================================
Coverage ? 70.11%
Complexity ? 483
=========================================
Files ? 29
Lines ? 1673
Branches ? 265
=========================================
Hits ? 1173
Misses ? 376
Partials ? 124Continue to review full report at Codecov.
|
Collaborator
Author
|
Note that the integration test is failing. I believe these tests would have been failing in the original google-cloud-java repo, but the integration tests for Storage NIO were not running. Those failing tests will not work given that we're running our tests on GCE instances and the default project will be found. We can fix these tests separately from this PR. |
BenWhitehead
approved these changes
Jan 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates a parent pom, adds our common templates and makes this repository releasable.
Note that the integration test is failing. I believe these tests would have been failing in the original google-cloud-java repo, but the integration tests for Storage NIO were not running. Those failing tests will not work given that we're running our tests on GCE instances and the default project will be found.