This repository was archived by the owner on Apr 2, 2026. It is now read-only.
fix: Make the StorageOption returned by LocalStorageHelper.getOptions() serializable#606
Merged
Merged
Conversation
(tweaked code to work with customOptions)
BenWhitehead
approved these changes
Jul 1, 2021
Collaborator
|
thanks for the contribution @jianglai! I've pushed an additional commit which also tests the |
Contributor
Author
|
Thank you! Any chance you can cut a release soon so that I can actually use it? |
Collaborator
|
We did a release last yesterday which is currently flowing out through the larger gcp library suite, so once that's complete we can easily cut a new release here. |
Contributor
Author
|
Hi Ben, do you have an ETA on when the next release is happening? |
Collaborator
|
Apologies on the delay, I've just triggered the release and it should be available on maven central soon. |
Collaborator
|
Release version is |
Contributor
Author
|
Many thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #605 ☕️