Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make the StorageOption returned by LocalStorageHelper.getOptions() serializable #606

Merged
merged 3 commits into from Jul 1, 2021

Conversation

jianglai
Copy link
Contributor

@jianglai jianglai commented Jul 1, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #605 ☕️

@jianglai jianglai requested a review from as a code owner Jul 1, 2021
@product-auto-label product-auto-label bot added the api: storage label Jul 1, 2021
@google-cla google-cla bot added the cla: yes label Jul 1, 2021
@jianglai jianglai changed the title Make the StorageOption returned by LocalStorageHelper.getOptions() serializable fix: Make the StorageOption returned by LocalStorageHelper.getOptions() serializable Jul 1, 2021
(tweaked code to work with customOptions)
@BenWhitehead
Copy link
Contributor

@BenWhitehead BenWhitehead commented Jul 1, 2021

thanks for the contribution @jianglai! I've pushed an additional commit which also tests the customOptions path (and slightly tweaked the factory to support that).

@BenWhitehead BenWhitehead added the automerge label Jul 1, 2021
@BenWhitehead BenWhitehead self-assigned this Jul 1, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 12e872b into googleapis:master Jul 1, 2021
17 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge label Jul 1, 2021
@jianglai jianglai deleted the serializable branch Jul 1, 2021
@jianglai
Copy link
Contributor Author

@jianglai jianglai commented Jul 1, 2021

Thank you! Any chance you can cut a release soon so that I can actually use it?

@BenWhitehead
Copy link
Contributor

@BenWhitehead BenWhitehead commented Jul 1, 2021

We did a release last yesterday which is currently flowing out through the larger gcp library suite, so once that's complete we can easily cut a new release here.

@jianglai
Copy link
Contributor Author

@jianglai jianglai commented Jul 30, 2021

Hi Ben, do you have an ETA on when the next release is happening?

@BenWhitehead
Copy link
Contributor

@BenWhitehead BenWhitehead commented Aug 2, 2021

Apologies on the delay, I've just triggered the release and it should be available on maven central soon.

@BenWhitehead
Copy link
Contributor

@BenWhitehead BenWhitehead commented Aug 2, 2021

Release version is v0.123.4

@jianglai
Copy link
Contributor Author

@jianglai jianglai commented Aug 3, 2021

Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants