-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add delimiter BlobListOption #102
Conversation
Codecov Report
@@ Coverage Diff @@
## master #102 +/- ##
============================================
+ Coverage 63.30% 63.62% +0.32%
- Complexity 528 539 +11
============================================
Files 30 30
Lines 4720 4729 +9
Branches 450 426 -24
============================================
+ Hits 2988 3009 +21
+ Misses 1571 1562 -9
+ Partials 161 158 -3
Continue to review full report at Codecov.
|
@@ -988,6 +988,11 @@ public static BlobListOption currentDirectory() { | |||
return new BlobListOption(StorageRpc.Option.DELIMITER, true); | |||
} | |||
|
|||
/** Returns an option to set a delimiter '/'. */ | |||
public static BlobListOption delimiter() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delimiter can be user defined, generally '/' is the one used most often, but I'd like to keep this open to other delimiters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@frankyn PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #99