-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for archive storage class #19
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19 +/- ##
===========================================
+ Coverage 63.29% 63.3% +<.01%
Complexity 528 528
===========================================
Files 30 30
Lines 4719 4720 +1
Branches 450 450
===========================================
+ Hits 2987 2988 +1
Misses 1571 1571
Partials 161 161
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. We can go ahead and merge this with a plan to release the change between 1/2-8
/** Durable Reduced Availability (deprecated) */ | ||
/** | ||
* Multi-regional storage class (deprecated). | ||
* See:https://cloud.google.com/storage/docs/storage-classes for details |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a space after the : (same below too)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
We're avoiding the term "Deprecated" for these concepts currently and opting for "legacy". Please replace the (deprecated) notes with "This is supported as a legacy storage class and will be deprecated in the future" |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after minor javadoc update
public static final StorageClass ARCHIVE = type.createAndRegister("ARCHIVE"); | ||
|
||
/** | ||
* Regional storage class.This is supported as a legacy storage class and will be deprecated in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a space - Regional storage class. This...
(same below)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@kolea2 @JesseLovelace PTAL |
Fixes #4