-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Blob.downloadTo() methods do not wrap RetryHelper$RetryHelperException #218
Conversation
Codecov Report
@@ Coverage Diff @@
## master #218 +/- ##
============================================
+ Coverage 63.50% 63.67% +0.17%
- Complexity 540 548 +8
============================================
Files 30 31 +1
Lines 4759 4785 +26
Branches 427 428 +1
============================================
+ Hits 3022 3047 +25
- Misses 1577 1578 +1
Partials 160 160
Continue to review full report at Codecov.
|
@@ -662,4 +661,25 @@ public Long answer() throws Throwable { | |||
byte actual[] = Files.readAllBytes(file.toPath()); | |||
assertArrayEquals(expected, actual); | |||
} | |||
|
|||
@Test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per Google practices, new tests should use Mockito, not EasyMock. Yes, even if this means some tests use Mockito and others use EasyMock.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this rule applied to the tests within a single file or withing a package?
Is it possible to make an exception?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think we will need to make an exception for now but may be good to file
an issue to track it as future work.
…On Wed, Apr 1, 2020, 11:57 PM Dmitry ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
google-cloud-storage/src/test/java/com/google/cloud/storage/BlobTest.java
<#218 (comment)>
:
> @@ -662,4 +661,25 @@ public Long answer() throws Throwable {
byte actual[] = Files.readAllBytes(file.toPath());
assertArrayEquals(expected, actual);
}
+
+ @test
Is this rule applied to the tests within a single file or withing a
package?
Is it possible to make an exception?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#218 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAORXQB5KYTBLUVFXI4DNWDRKQZMBANCNFSM4LXMU2UQ>
.
|
Fixes #100