chore: generate README from templates #238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #238 +/- ##
=========================================
Coverage 63.52% 63.52%
Complexity 540 540
=========================================
Files 30 30
Lines 4776 4776
Branches 431 431
=========================================
Hits 3034 3034
Misses 1580 1580
Partials 162 162 Continue to review full report at Codecov.
|
Closed
chingor13
force-pushed
the
generate-readme
branch
from
7080cd3 to
aa69caf
Compare
frankyn
suggested changes
Apr 14, 2020
Contributor
frankyn
left a comment
frankyn
left a comment
There was a problem hiding this comment.
Overall, LGTM, pending one question.
README.md
Outdated
| Java 7 or above is required for using this client. | ||
|
|
||
| Contributions to this library are always welcome and highly encouraged. | ||
| ## Versioning |
Contributor
There was a problem hiding this comment.
@chingor13 how can I update versioning information for this library based on discussions around the Storage interface?
Contributor
Author
There was a problem hiding this comment.
I'll need to add an opt-out in the shared template configuration
Contributor
There was a problem hiding this comment.
Gotcha, is this something you want to do after this PR?
frankyn
added
the
kokoro:force-run
frankyn
approved these changes
Apr 14, 2020
yoshi-kokoro
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom content is now in
.readme-partials.yamlso any updates need to go there for now. This will allow automatic updates to the install sections for the latest libraries-bom versions and keep our README format in sync with the other client libraries.Also fixes a few broken links to the google-cloud-examples that still live in the monorepo.