Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support of customTimeBefore and daysSinceCustomTime #396

Merged
merged 5 commits into from
Aug 27, 2020
Merged

feat: add support of customTimeBefore and daysSinceCustomTime #396

merged 5 commits into from
Aug 27, 2020

Conversation

athakor
Copy link
Contributor

@athakor athakor commented Jun 26, 2020 •
edited
Loading

Towards #395

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 26, 2020
@athakor athakor requested review from frankyn and JesseLovelace June 26, 2020 13:44
@codecov
Copy link

codecov bot commented Jun 26, 2020 •
edited
Loading

Codecov Report

Merging #396 into master will increase coverage by 0.02%.
The diff coverage is 68.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #396      +/-   ##
============================================
+ Coverage     64.49%   64.52%   +0.02%     
+ Complexity      623      614       -9     
============================================
  Files            32       32              
  Lines          5199     5220      +21     
  Branches        501      505       +4     
============================================
+ Hits           3353     3368      +15     
- Misses         1687     1693       +6     
  Partials        159      159
Impacted Files Coverage Δ Complexity Δ
...main/java/com/google/cloud/storage/BucketInfo.java 83.97% <68.00%> (-0.42%) 86.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf94230...e03f8cb. Read the comment docs.

@frankyn
Copy link
Contributor

frankyn commented Jun 26, 2020

@jkwlui

@frankyn frankyn added the status: blocked Resolving the issue is dependent on other work. label Jun 29, 2020
@athakor athakor added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 9, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 9, 2020
@athakor athakor added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Jul 25, 2020
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 25, 2020
@athakor athakor added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 5, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 5, 2020
frankyn
frankyn approved these changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @athakor,

Update: The Cloud Storage team has updated type of noncurrent_time_before and custom_time to be a Date format (YYYY-mm-dd) instead of DateTime.

Discovery document with updated documentation with respect to these fields:
https://www.googleapis.com/discovery/v1/apis/storage/v1/rest

This has been updated in the latest release dependency in PR (#457). Please update relevant documentation.

frankyn
frankyn suggested changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @athakor,

Update: The Cloud Storage team has updated type of noncurrent_time_before and custom_time to be a Date format (YYYY-mm-dd) instead of DateTime.

Discovery document with updated documentation with respect to these fields:
https://www.googleapis.com/discovery/v1/apis/storage/v1/rest

This has been updated in the latest release dependency in PR (#457). Please update relevant documentation.

@athakor
Copy link
Contributor Author

athakor commented Aug 13, 2020 •
edited
Loading

Hi @athakor,

Update: The Cloud Storage team has updated type of noncurrent_time_before and custom_time to be a Date format (YYYY-mm-dd) instead of DateTime.

Discovery document with updated documentation with respect to these fields:
https://www.googleapis.com/discovery/v1/apis/storage/v1/rest

This has been updated in the latest release dependency in PR (#457). Please update relevant documentation.

@frankyn That change has been already done also updated the relevant java doc.

@frankyn frankyn removed the status: blocked Resolving the issue is dependent on other work. label Aug 24, 2020
@athakor
Copy link
Contributor Author

athakor commented Aug 26, 2020

@jkwlui @JesseLovelace PTAL

JesseLovelace
JesseLovelace reviewed Aug 26, 2020
View reviewed changes
google-cloud-storage/src/main/java/com/google/cloud/storage/BucketInfo.java Outdated
@@ -532,13 +549,25 @@ public Boolean getIsLive() {
return matchesStorageClass;
}

/* Returns the date in RFC 3339 format with only the date part (for instance, "2013-01-15")*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

End this with a period, i.e. "(for instance, "2013-01-15"). */"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@frankyn frankyn merged commit 1af8288 into googleapis:master Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesseLovelace JesseLovelace JesseLovelace left review comments

@frankyn frankyn frankyn approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@athakor @frankyn @JesseLovelace @googlebot @yoshi-kokoro