-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support of null to remove the CORS configuration from bucket #438
Conversation
Codecov Report
@@ Coverage Diff @@
## master #438 +/- ##
============================================
+ Coverage 63.15% 63.17% +0.01%
- Complexity 610 619 +9
============================================
Files 32 32
Lines 5133 5133
Branches 490 489 -1
============================================
+ Hits 3242 3243 +1
Misses 1726 1726
+ Partials 165 164 -1
Continue to review full report at Codecov.
|
@@ -1509,7 +1509,7 @@ public StorageClass getStorageClass() { | |||
* (CORS)</a> | |||
*/ | |||
public List<Cors> getCors() { | |||
return cors; | |||
return cors != null ? cors : ImmutableList.<Cors>of(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please leave this field as is and revert change. There are potentially 4 cases which are considered here and we don't want to mess them up.
- Cors are set and field selector is selected then returns not-null.
- Cors are set but field selector isn't selected then returns null.
- Cors are not set and field selector is selected then returns null.
- Cors are not set and field selector isn't selected then returns null.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@frankyn PTAL |
Fixes #437