Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: adopt the new multi-pattern resource names #88

Merged
merged 7 commits into from Mar 13, 2020

Conversation

yihanzhen
Copy link
Contributor

@yihanzhen yihanzhen commented Mar 12, 2020

  • Delete TenantOrProjectName.
  • Generate overloads that take TenantName and ProjectName respectively where TenantOrProjectName was originally used.
  • Delete per-pattern resource name helper classes: CompanyWithTenantName, CompanyWithoutTenantName, JobWithTenantName, JobWithoutTenantName, CompanyOldName, CompanyNewName, JobOldName, JobNewName.
  • Delete resource name factory classes JobNames, CompanyNames, TenantOrProjectNames and untyped resource name classes UntypedJobName, UntypedTenantName and UntypedTenantOrProjectName.

@googlebot googlebot added the cla: yes label Mar 12, 2020
@codecov
Copy link

@codecov codecov bot commented Mar 12, 2020

Codecov Report

Merging #88 into master will decrease coverage by 1.18%.
The diff coverage is 73.45%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #88      +/-   ##
============================================
- Coverage     71.87%   70.69%   -1.19%     
  Complexity      331      331              
============================================
  Files            42       42              
  Lines          2642     2692      +50     
  Branches         15       15              
============================================
+ Hits           1899     1903       +4     
- Misses          706      750      +44     
- Partials         37       39       +2
Impacted Files Coverage Δ Complexity Δ
.../google/cloud/talent/v4beta1/CompletionClient.java 37.5% <ø> (ø) 5 <0> (ø) ⬇️
...e/cloud/talent/v4beta1/CompanyServiceSettings.java 18.91% <0%> (ø) 2 <0> (ø) ⬇️
...le/cloud/talent/v4beta1/TenantServiceSettings.java 18.91% <0%> (ø) 2 <0> (ø) ⬇️
.../cloud/talent/v4beta1/stub/CompanyServiceStub.java 14.28% <0%> (ø) 1 <0> (ø) ⬇️
...e/cloud/talent/v4beta1/stub/TenantServiceStub.java 14.28% <0%> (ø) 1 <0> (ø) ⬇️
...e/cloud/talent/v4beta1/ProfileServiceSettings.java 17.94% <0%> (ø) 2 <0> (ø) ⬇️
...oogle/cloud/talent/v4beta1/EventServiceClient.java 36.11% <0%> (-5.83%) 6 <0> (ø)
...ogle/cloud/talent/v4beta1/stub/JobServiceStub.java 5.88% <0%> (ø) 1 <0> (ø) ⬇️
...ud/talent/v4beta1/stub/ApplicationServiceStub.java 14.28% <0%> (ø) 1 <0> (ø) ⬇️
.../cloud/talent/v4beta1/stub/ProfileServiceStub.java 11.11% <0%> (ø) 1 <0> (ø) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e2a860...5ec8f9f. Read the comment docs.

@yihanzhen
Copy link
Contributor Author

@yihanzhen yihanzhen commented Mar 12, 2020

PTAL @chingor13

@@ -16,4 +16,13 @@
<className>com/google/cloud/talent/v4beta1/*OrBuilder</className>
<method>boolean has*(*)</method>
</difference>
<difference>
<differenceType>8001</differenceType>
<className>com/google/cloud/talent/v4beta1/*Name*</className>
Copy link
Collaborator

@chingor13 chingor13 Mar 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's be more explicit on exactly which classes are ok to remove in this PR.

Copy link
Contributor Author

@yihanzhen yihanzhen Mar 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

<?xml version="1.0" encoding="UTF-8"?>
<!-- see http://www.mojohaus.org/clirr-maven-plugin/examples/ignored-differences.html -->
<differences>
<!--TODO: To be removed-->
Copy link
Collaborator

@chingor13 chingor13 Mar 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add after 0.36.0

Copy link
Contributor Author

@yihanzhen yihanzhen Mar 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@chingor13 chingor13 merged commit 0a8a4c9 into googleapis:master Mar 13, 2020
15 checks passed
@release-please release-please bot mentioned this pull request Mar 13, 2020
vam-google pushed a commit to vam-google/java-talent that referenced this issue Mar 20, 2020
…gleapis#88)

* chore: update repo-metadata and regenerate README from templates

* restore examples

* fix pretty name
@release-please release-please bot mentioned this pull request Mar 27, 2020
@chingor13 chingor13 mentioned this pull request Mar 27, 2020
@chingor13 chingor13 mentioned this pull request Mar 27, 2020
@release-please release-please bot mentioned this pull request Mar 27, 2020
gcf-merge-on-green bot pushed a commit that referenced this issue Mar 27, 2020
🤖 I have created a release \*beep\* \*boop\* 
---
## [0.36.0](https://www.github.com/googleapis/java-talent/compare/v0.35.2...v0.36.0) (2020-03-27)


###  BREAKING CHANGES

* use `TenantName` for resources in place of `TenantOrProjectName`
* adopt the new multi-pattern resource names (#88)

### Features

* adopt the new multi-pattern resource names ([#88](https://www.github.com/googleapis/java-talent/issues/88)) ([0a8a4c9](https://www.github.com/googleapis/java-talent/commit/0a8a4c9141e5b024ab4106975690f6b3f1c91bf3))
* resource name change ([#106](https://www.github.com/googleapis/java-talent/issues/106)) ([2c44fa8](https://www.github.com/googleapis/java-talent/commit/2c44fa85b84cb8b64715a784b9c960a0ac23065c))


### Bug Fixes

* undeprecate resource name classes until multi-pattern resources are available ([#83](https://www.github.com/googleapis/java-talent/issues/83)) ([c6ac9f8](https://www.github.com/googleapis/java-talent/commit/c6ac9f825e122cd4805f51ae5ef3fc9e2185ca1b))


### Dependencies

* update core dependencies ([#84](https://www.github.com/googleapis/java-talent/issues/84)) ([2824acd](https://www.github.com/googleapis/java-talent/commit/2824acd3d725f7a2b2c246dad5140e248ceb318c))
* update dependency com.google.api:api-common to v1.9.0 ([#108](https://www.github.com/googleapis/java-talent/issues/108)) ([3e9cd1f](https://www.github.com/googleapis/java-talent/commit/3e9cd1fbd46f00d83dd5cedcce487644ba7eb465))
* update dependency com.google.cloud:google-cloud-core to v1.92.5 ([bd15e46](https://www.github.com/googleapis/java-talent/commit/bd15e4646a653e0951999a35336c472bc3c1661c))
* update dependency com.google.protobuf:protobuf-java to v3.11.4 ([e6ca466](https://www.github.com/googleapis/java-talent/commit/e6ca46662f9f78760fde934e23deaa1d4582d604))
* update dependency io.grpc:grpc-bom to v1.27.1 ([b9a488d](https://www.github.com/googleapis/java-talent/commit/b9a488d3356e772131a427934011d5f4543fac2c))


### Documentation

* **regen:** update generate proto documentation ([#86](https://www.github.com/googleapis/java-talent/issues/86)) ([3e2a860](https://www.github.com/googleapis/java-talent/commit/3e2a860d3d10cb46dcbe97582afc0b283d591f01))
* **regen:** update sample code to set total timeout, add API client header test ([10922f4](https://www.github.com/googleapis/java-talent/commit/10922f4c050ea3a54e57c30d5963d95e749228dd))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
yoshi-automation added a commit that referenced this issue Mar 27, 2020
4a4a1df
commit 4a4a1df
Author: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Date:   Fri Mar 27 21:44:09 2020 +0000

    chore: release 0.36.0 (#113)

    🤖 I have created a release \*beep\* \*boop\*
    ---
    ## [0.36.0](https://www.github.com/googleapis/java-talent/compare/v0.35.2...v0.36.0) (2020-03-27)

    ###  BREAKING CHANGES

    * use `TenantName` for resources in place of `TenantOrProjectName`
    * adopt the new multi-pattern resource names (#88)

    ### Features

    * adopt the new multi-pattern resource names ([#88](https://www.github.com/googleapis/java-talent/issues/88)) ([0a8a4c9](https://www.github.com/googleapis/java-talent/commit/0a8a4c9141e5b024ab4106975690f6b3f1c91bf3))
    * resource name change ([#106](https://www.github.com/googleapis/java-talent/issues/106)) ([2c44fa8](https://www.github.com/googleapis/java-talent/commit/2c44fa85b84cb8b64715a784b9c960a0ac23065c))

    ### Bug Fixes

    * undeprecate resource name classes until multi-pattern resources are available ([#83](https://www.github.com/googleapis/java-talent/issues/83)) ([c6ac9f8](https://www.github.com/googleapis/java-talent/commit/c6ac9f825e122cd4805f51ae5ef3fc9e2185ca1b))

    ### Dependencies

    * update core dependencies ([#84](https://www.github.com/googleapis/java-talent/issues/84)) ([2824acd](https://www.github.com/googleapis/java-talent/commit/2824acd3d725f7a2b2c246dad5140e248ceb318c))
    * update dependency com.google.api:api-common to v1.9.0 ([#108](https://www.github.com/googleapis/java-talent/issues/108)) ([3e9cd1f](https://www.github.com/googleapis/java-talent/commit/3e9cd1fbd46f00d83dd5cedcce487644ba7eb465))
    * update dependency com.google.cloud:google-cloud-core to v1.92.5 ([bd15e46](https://www.github.com/googleapis/java-talent/commit/bd15e4646a653e0951999a35336c472bc3c1661c))
    * update dependency com.google.protobuf:protobuf-java to v3.11.4 ([e6ca466](https://www.github.com/googleapis/java-talent/commit/e6ca46662f9f78760fde934e23deaa1d4582d604))
    * update dependency io.grpc:grpc-bom to v1.27.1 ([b9a488d](https://www.github.com/googleapis/java-talent/commit/b9a488d3356e772131a427934011d5f4543fac2c))

    ### Documentation

    * **regen:** update generate proto documentation ([#86](https://www.github.com/googleapis/java-talent/issues/86)) ([3e2a860](https://www.github.com/googleapis/java-talent/commit/3e2a860d3d10cb46dcbe97582afc0b283d591f01))
    * **regen:** update sample code to set total timeout, add API client header test ([10922f4](https://www.github.com/googleapis/java-talent/commit/10922f4c050ea3a54e57c30d5963d95e749228dd))
    ---

    This PR was generated with [Release Please](https://github.com/googleapis/release-please).
yoshi-automation added a commit that referenced this issue Mar 28, 2020
4a4a1df
commit 4a4a1df
Author: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Date:   Fri Mar 27 21:44:09 2020 +0000

    chore: release 0.36.0 (#113)

    🤖 I have created a release \*beep\* \*boop\*
    ---
    ## [0.36.0](https://www.github.com/googleapis/java-talent/compare/v0.35.2...v0.36.0) (2020-03-27)

    ###  BREAKING CHANGES

    * use `TenantName` for resources in place of `TenantOrProjectName`
    * adopt the new multi-pattern resource names (#88)

    ### Features

    * adopt the new multi-pattern resource names ([#88](https://www.github.com/googleapis/java-talent/issues/88)) ([0a8a4c9](https://www.github.com/googleapis/java-talent/commit/0a8a4c9141e5b024ab4106975690f6b3f1c91bf3))
    * resource name change ([#106](https://www.github.com/googleapis/java-talent/issues/106)) ([2c44fa8](https://www.github.com/googleapis/java-talent/commit/2c44fa85b84cb8b64715a784b9c960a0ac23065c))

    ### Bug Fixes

    * undeprecate resource name classes until multi-pattern resources are available ([#83](https://www.github.com/googleapis/java-talent/issues/83)) ([c6ac9f8](https://www.github.com/googleapis/java-talent/commit/c6ac9f825e122cd4805f51ae5ef3fc9e2185ca1b))

    ### Dependencies

    * update core dependencies ([#84](https://www.github.com/googleapis/java-talent/issues/84)) ([2824acd](https://www.github.com/googleapis/java-talent/commit/2824acd3d725f7a2b2c246dad5140e248ceb318c))
    * update dependency com.google.api:api-common to v1.9.0 ([#108](https://www.github.com/googleapis/java-talent/issues/108)) ([3e9cd1f](https://www.github.com/googleapis/java-talent/commit/3e9cd1fbd46f00d83dd5cedcce487644ba7eb465))
    * update dependency com.google.cloud:google-cloud-core to v1.92.5 ([bd15e46](https://www.github.com/googleapis/java-talent/commit/bd15e4646a653e0951999a35336c472bc3c1661c))
    * update dependency com.google.protobuf:protobuf-java to v3.11.4 ([e6ca466](https://www.github.com/googleapis/java-talent/commit/e6ca46662f9f78760fde934e23deaa1d4582d604))
    * update dependency io.grpc:grpc-bom to v1.27.1 ([b9a488d](https://www.github.com/googleapis/java-talent/commit/b9a488d3356e772131a427934011d5f4543fac2c))

    ### Documentation

    * **regen:** update generate proto documentation ([#86](https://www.github.com/googleapis/java-talent/issues/86)) ([3e2a860](https://www.github.com/googleapis/java-talent/commit/3e2a860d3d10cb46dcbe97582afc0b283d591f01))
    * **regen:** update sample code to set total timeout, add API client header test ([10922f4](https://www.github.com/googleapis/java-talent/commit/10922f4c050ea3a54e57c30d5963d95e749228dd))
    ---

    This PR was generated with [Release Please](https://github.com/googleapis/release-please).
yoshi-automation added a commit that referenced this issue Apr 2, 2020
4a4a1df
commit 4a4a1df
Author: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Date:   Fri Mar 27 21:44:09 2020 +0000

    chore: release 0.36.0 (#113)

    🤖 I have created a release \*beep\* \*boop\*
    ---
    ## [0.36.0](https://www.github.com/googleapis/java-talent/compare/v0.35.2...v0.36.0) (2020-03-27)

    ###  BREAKING CHANGES

    * use `TenantName` for resources in place of `TenantOrProjectName`
    * adopt the new multi-pattern resource names (#88)

    ### Features

    * adopt the new multi-pattern resource names ([#88](https://www.github.com/googleapis/java-talent/issues/88)) ([0a8a4c9](https://www.github.com/googleapis/java-talent/commit/0a8a4c9141e5b024ab4106975690f6b3f1c91bf3))
    * resource name change ([#106](https://www.github.com/googleapis/java-talent/issues/106)) ([2c44fa8](https://www.github.com/googleapis/java-talent/commit/2c44fa85b84cb8b64715a784b9c960a0ac23065c))

    ### Bug Fixes

    * undeprecate resource name classes until multi-pattern resources are available ([#83](https://www.github.com/googleapis/java-talent/issues/83)) ([c6ac9f8](https://www.github.com/googleapis/java-talent/commit/c6ac9f825e122cd4805f51ae5ef3fc9e2185ca1b))

    ### Dependencies

    * update core dependencies ([#84](https://www.github.com/googleapis/java-talent/issues/84)) ([2824acd](https://www.github.com/googleapis/java-talent/commit/2824acd3d725f7a2b2c246dad5140e248ceb318c))
    * update dependency com.google.api:api-common to v1.9.0 ([#108](https://www.github.com/googleapis/java-talent/issues/108)) ([3e9cd1f](https://www.github.com/googleapis/java-talent/commit/3e9cd1fbd46f00d83dd5cedcce487644ba7eb465))
    * update dependency com.google.cloud:google-cloud-core to v1.92.5 ([bd15e46](https://www.github.com/googleapis/java-talent/commit/bd15e4646a653e0951999a35336c472bc3c1661c))
    * update dependency com.google.protobuf:protobuf-java to v3.11.4 ([e6ca466](https://www.github.com/googleapis/java-talent/commit/e6ca46662f9f78760fde934e23deaa1d4582d604))
    * update dependency io.grpc:grpc-bom to v1.27.1 ([b9a488d](https://www.github.com/googleapis/java-talent/commit/b9a488d3356e772131a427934011d5f4543fac2c))

    ### Documentation

    * **regen:** update generate proto documentation ([#86](https://www.github.com/googleapis/java-talent/issues/86)) ([3e2a860](https://www.github.com/googleapis/java-talent/commit/3e2a860d3d10cb46dcbe97582afc0b283d591f01))
    * **regen:** update sample code to set total timeout, add API client header test ([10922f4](https://www.github.com/googleapis/java-talent/commit/10922f4c050ea3a54e57c30d5963d95e749228dd))
    ---

    This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants