Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bom should not reference itself #28

merged 1 commit into from Nov 26, 2019

fix: bom should not reference itself #28

merged 1 commit into from Nov 26, 2019


Copy link

@chingor13 chingor13 commented Nov 26, 2019

Fixes #27

@googlebot googlebot added the cla: yes label Nov 26, 2019
@chingor13 chingor13 requested a review from Nov 26, 2019
elharo approved these changes Nov 26, 2019
@chingor13 chingor13 merged commit 59fc67b into master Nov 26, 2019
9 of 10 checks passed
@chingor13 chingor13 deleted the chingor13-patch-1 branch Nov 26, 2019
Copy link

@codecov codecov bot commented Nov 26, 2019

Codecov Report

Merging #28 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #28   +/-   ##
  Coverage     64.14%   64.14%           
  Complexity      191      191           
  Files            36       36           
  Lines          1283     1283           
  Branches          6        6           
  Hits            823      823           
  Misses          454      454           
  Partials          6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03ceaae...793d937. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
cla: yes
None yet

Successfully merging this pull request may close these issues.

3 participants