Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify that project number is used as the canonical project identifier for job and job template names #247

Merged
merged 3 commits into from Oct 8, 2021

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Oct 5, 2021

docs: fix broken link and code formatting
feat: add support for allow_missing param on DELETE request
fix!: remove Encryption settings that were published due to a sync issue
BREAKING CHANGE: requests specifying Encryption settings are rejected by the server

  • Regenerate this pull request now.

PiperOrigin-RevId: 401033248

Source-Link: googleapis/googleapis@ef9130f

Source-Link: googleapis/googleapis-gen@9ebec33
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOWViZWMzMzQ2YTY0NjkwYzA2M2ViNzJmMWIxYzFkNmQyNzkxNzdjZSJ9

…entifier for job and job template names docs: fix broken link and code formatting feat: add support for allow_missing param on DELETE request fix!: remove Encryption settings that were published due to a sync issue BREAKING CHANGE: requests specifying Encryption settings are rejected by the server

PiperOrigin-RevId: 401033248

Source-Link: googleapis/googleapis@ef9130f

Source-Link: https://github.com/googleapis/googleapis-gen/commit/9ebec3346a64690c063eb72f1b1c1d6d279177ce
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOWViZWMzMzQ2YTY0NjkwYzA2M2ViNzJmMWIxYzFkNmQyNzkxNzdjZSJ9
@gcf-owl-bot gcf-owl-bot bot requested a review from as a code owner Oct 5, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run owlbot:run labels Oct 5, 2021
@product-auto-label product-auto-label bot added the api: transcoder label Oct 5, 2021
@google-cla google-cla bot added the cla: yes label Oct 5, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Oct 5, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Oct 5, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run owlbot:run labels Oct 5, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Oct 5, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Oct 5, 2021
@Neenu1995 Neenu1995 changed the title docs: clarify that project number is used as the canonical project identifier for job and job template names docs: fix broken link and code formatting feat: add support for allow_missing param on DELETE request fix!: remove Encryption settings that wer... docs: clarify that project number is used as the canonical project identifier for job and job template names Oct 5, 2021
@Neenu1995 Neenu1995 added the do not merge label Oct 5, 2021
@Neenu1995
Copy link
Contributor

@Neenu1995 Neenu1995 commented Oct 5, 2021

verify the breaking change before merging.

@chanseokoh
Copy link
Contributor

@chanseokoh chanseokoh commented Oct 8, 2021

verify the breaking change before merging.

Looks like the clirr errors are all about Encryption. The PR description says

fix!: remove Encryption settings that were published due to a sync issue

So I think it was an accident that these were published, and this PR is correcting them.

@chanseokoh
Copy link
Contributor

@chanseokoh chanseokoh commented Oct 8, 2021

@Neenu1995 does the above make sense?

@Neenu1995
Copy link
Contributor

@Neenu1995 Neenu1995 commented Oct 8, 2021

Looking at the discussion in the CL, looks like this doesn't break any customers. Also, java is pre GA for this library. So we can take on the change as a minor version bump.

@Neenu1995 Neenu1995 removed the do not merge label Oct 8, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run owlbot:run labels Oct 8, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Oct 8, 2021
@chanseokoh chanseokoh added the automerge label Oct 8, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Oct 8, 2021
@chanseokoh chanseokoh merged commit 27b43b5 into main Oct 8, 2021
18 checks passed
@chanseokoh chanseokoh deleted the owl-bot-9dcc8174-76a4-4605-a3cf-5e82378c4fd3 branch Oct 8, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge label Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: transcoder cla: yes owl-bot-copy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants