New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: clarify that project number is used as the canonical project identifier for job and job template names #247
Conversation
…entifier for job and job template names docs: fix broken link and code formatting feat: add support for allow_missing param on DELETE request fix!: remove Encryption settings that were published due to a sync issue BREAKING CHANGE: requests specifying Encryption settings are rejected by the server PiperOrigin-RevId: 401033248 Source-Link: googleapis/googleapis@ef9130f Source-Link: https://github.com/googleapis/googleapis-gen/commit/9ebec3346a64690c063eb72f1b1c1d6d279177ce Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOWViZWMzMzQ2YTY0NjkwYzA2M2ViNzJmMWIxYzFkNmQyNzkxNzdjZSJ9
verify the breaking change before merging. |
Looks like the clirr errors are all about Encryption. The PR description says
So I think it was an accident that these were published, and this PR is correcting them. |
@Neenu1995 does the above make sense? |
Looking at the discussion in the CL, looks like this doesn't break any customers. Also, java is pre GA for this library. So we can take on the change as a minor version bump. |
docs: fix broken link and code formatting
feat: add support for allow_missing param on DELETE request
fix!: remove Encryption settings that were published due to a sync issue
BREAKING CHANGE: requests specifying Encryption settings are rejected by the server
PiperOrigin-RevId: 401033248
Source-Link: googleapis/googleapis@ef9130f
Source-Link: googleapis/googleapis-gen@9ebec33
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOWViZWMzMzQ2YTY0NjkwYzA2M2ViNzJmMWIxYzFkNmQyNzkxNzdjZSJ9