Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v1): add v1 client #84

Merged
merged 1 commit into from Mar 16, 2020
Merged

feat(v1): add v1 client #84

merged 1 commit into from Mar 16, 2020

Conversation

chingor13
Copy link
Collaborator

@chingor13 chingor13 commented Mar 16, 2020

Also, switch to bazel generator

@chingor13 chingor13 requested a review from Mar 16, 2020
@googlebot googlebot added the cla: yes label Mar 16, 2020
private static volatile io.grpc.MethodDescriptor<
com.google.webrisk.v1beta1.SearchHashesRequest,
com.google.webrisk.v1beta1.SearchHashesResponse>
getSearchHashesMethod;

@io.grpc.ExperimentalApi("https://github.com/grpc/grpc-java/issues/1901")
@io.grpc.stub.annotations.RpcMethod(
Copy link
Contributor

@kolea2 kolea2 Mar 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just want to confirm these are intended changes as part of adding a v1 client?

Copy link
Collaborator Author

@chingor13 chingor13 Mar 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an artifact of switching to the bazel generator (grpc plugin update). I can separate this into a different PR

Copy link
Contributor

@kolea2 kolea2 Mar 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your call, just wanted to confirm! I'll approve this PR, feel free to separate out if needed

Copy link
Collaborator Author

@chingor13 chingor13 Mar 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the v1beta1 stuff and will do it separately for a cleaner commit history

@codecov
Copy link

@codecov codecov bot commented Mar 16, 2020

Codecov Report

Merging #84 into master will increase coverage by 1.11%.
The diff coverage is 69.96%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #84      +/-   ##
============================================
+ Coverage      67.9%   69.01%   +1.11%     
- Complexity       38       81      +43     
============================================
  Files             6       12       +6     
  Lines           243      526     +283     
  Branches          1        2       +1     
============================================
+ Hits            165      363     +198     
- Misses           77      160      +83     
- Partials          1        3       +2
Impacted Files Coverage Δ Complexity Δ
...oogle/cloud/webrisk/v1/WebRiskServiceSettings.java 20% <20%> (ø) 2 <2> (?)
...ogle/cloud/webrisk/v1/stub/WebRiskServiceStub.java 20% <20%> (ø) 1 <1> (?)
...isk/v1/stub/GrpcWebRiskServiceCallableFactory.java 25% <25%> (ø) 2 <2> (?)
.../google/cloud/webrisk/v1/WebRiskServiceClient.java 64% <64%> (ø) 15 <15> (?)
...ud/webrisk/v1/stub/WebRiskServiceStubSettings.java 80.58% <80.58%> (ø) 13 <13> (?)
.../cloud/webrisk/v1/stub/GrpcWebRiskServiceStub.java 89.02% <89.02%> (ø) 10 <10> (?)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fdf604...5430a45. Read the comment docs.

kolea2
kolea2 approved these changes Mar 16, 2020
@chingor13 chingor13 merged commit 4d88859 into master Mar 16, 2020
15 checks passed
@chingor13 chingor13 deleted the v1 branch Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants