Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update the admin APIs #485

Merged
merged 5 commits into from Jun 21, 2019
Merged

feat: update the admin APIs #485

merged 5 commits into from Jun 21, 2019

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 馃寛

Here's the log from Synthtool:

synthtool > Executing /tmpfs/src/git/autosynth/working_repo/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:3246adac900f4bdbd62920e80de2e5877380e44036b3feae13667ec255ebf5ec
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/bigtable/artman_bigtable.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/js/bigtable-v2.
synthtool > Replaced '../../package.json' in src/v2/bigtable_client.js.
.eslintignore
.eslintrc.yml
.github/ISSUE_TEMPLATE/bug_report.md
.github/ISSUE_TEMPLATE/feature_request.md
.github/ISSUE_TEMPLATE/support_request.md
.jsdoc.js
.kokoro/common.cfg
.kokoro/continuous/node10/common.cfg
.kokoro/continuous/node10/docs.cfg
.kokoro/continuous/node10/lint.cfg
.kokoro/continuous/node10/samples-test.cfg
.kokoro/continuous/node10/system-test.cfg
.kokoro/continuous/node10/test.cfg
.kokoro/continuous/node11/common.cfg
.kokoro/continuous/node11/test.cfg
.kokoro/continuous/node8/common.cfg
.kokoro/continuous/node8/test.cfg
.kokoro/docs.sh
.kokoro/lint.sh
.kokoro/presubmit/node10/common.cfg
.kokoro/presubmit/node10/docs.cfg
.kokoro/presubmit/node10/lint.cfg
.kokoro/presubmit/node10/samples-test.cfg
.kokoro/presubmit/node10/system-test.cfg
.kokoro/presubmit/node10/test.cfg
.kokoro/presubmit/node11/common.cfg
.kokoro/presubmit/node11/test.cfg
.kokoro/presubmit/node8/common.cfg
.kokoro/presubmit/node8/test.cfg
.kokoro/presubmit/windows/common.cfg
.kokoro/presubmit/windows/test.cfg
.kokoro/publish.sh
.kokoro/release/publish.cfg
.kokoro/samples-test.sh
.kokoro/system-test.sh
.kokoro/test.bat
.kokoro/test.sh
.kokoro/trampoline.sh
.nycrc
.prettierignore
.prettierrc
CODE_OF_CONDUCT.md
CONTRIBUTING.md
LICENSE
Skipping: README.md
codecov.yaml
renovate.json
Skipping: samples/README.md

> core-js@2.6.7 postinstall /tmpfs/src/git/autosynth/working_repo/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)


> protobufjs@6.8.8 postinstall /tmpfs/src/git/autosynth/working_repo/node_modules/protobufjs
> node scripts/postinstall


> @google-cloud/bigtable@1.0.1 prepare /tmpfs/src/git/autosynth/working_repo
> npm run compile


> @google-cloud/bigtable@1.0.1 compile /tmpfs/src/git/autosynth/working_repo
> tsc -p . && cp -r src/v2 build/src/ && cp -r proto* build/ && cp test/*.js build/test

npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.9 (node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.9: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

added 971 packages from 1366 contributors and audited 6285 packages in 33.832s
found 0 vulnerabilities


> @google-cloud/bigtable@1.0.1 fix /tmpfs/src/git/autosynth/working_repo
> gts fix && npm run lintfix


> @google-cloud/bigtable@1.0.1 lintfix /tmpfs/src/git/autosynth/working_repo
> eslint --fix '**/*.js'

synthtool > Cleaned up 2 temporary directories.
synthtool > Wrote metadata to synth.metadata.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 21, 2019
@codecov
Copy link

codecov bot commented May 21, 2019

Codecov Report

Merging #485 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #485   +/-   ##
=======================================
  Coverage   97.85%   97.85%           
=======================================
  Files          10       10           
  Lines        1303     1303           
  Branches      345      345           
=======================================
  Hits         1275     1275           
  Partials       28       28
Impacted Files Coverage 螖
src/index.ts 99.23% <酶> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 89124f6...26b6a9d. Read the comment docs.

@JustinBeckwith JustinBeckwith changed the title [CHANGE ME] Re-generated to pick up changes in the API or client library generator. feat: update the admin APIs May 21, 2019
@@ -0,0 +1,90 @@
// Copyright 2019 Google LLC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be here?

@@ -0,0 +1,63 @@
// Copyright 2019 Google LLC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this file be here?

@@ -0,0 +1,34 @@
// Copyright 2019 Google LLC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this file?

@@ -0,0 +1,51 @@
// Copyright 2019 Google LLC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question.

@crwilcox
Copy link
Contributor

There are a few file additions I would like to be sure we want. @JustinBeckwith @jkwlui

@jkwlui
Copy link
Member

jkwlui commented May 29, 2019

Good catch @crwilcox
Looking at those files I can't figure out why they're there - none of these types are referenced by any RPC, so they shouldn't really be generated. @alexander-fenster can you take a look from the generator's perspective?

@yoshi-automation yoshi-automation added the 馃毃 This issue needs some love. label Jun 4, 2019
@crwilcox crwilcox merged commit c76fba9 into master Jun 21, 2019
@yoshi-automation yoshi-automation removed the 馃毃 This issue needs some love. label Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants