From fe8f2009fa09b27572d22759e3affce0455dc760 Mon Sep 17 00:00:00 2001 From: Jeff Ching Date: Wed, 23 Mar 2022 12:16:57 -0700 Subject: [PATCH 1/7] feat!: make v1 default service version feat: promote to stable --- .repo-metadata.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.repo-metadata.json b/.repo-metadata.json index c62269e..332013c 100644 --- a/.repo-metadata.json +++ b/.repo-metadata.json @@ -2,8 +2,8 @@ "client_documentation": "https://cloud.google.com/nodejs/docs/reference/binary-authorization/latest", "api_id": "binaryauthorization.googleapis.com", "distribution_name": "@google-cloud/binary-authorization", - "release_level": "preview", - "default_version": "v1beta1", + "release_level": "stable", + "default_version": "v1", "language": "nodejs", "name_pretty": "Binary Authorization", "repo": "googleapis/nodejs-binary-authorization", From d97d5ffe8e85a881fceec5ab4dc9abdb06ade82d Mon Sep 17 00:00:00 2001 From: Owl Bot Date: Wed, 23 Mar 2022 19:18:46 +0000 Subject: [PATCH 2/7] =?UTF-8?q?=F0=9F=A6=89=20Updates=20from=20OwlBot=20po?= =?UTF-8?q?st-processor?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --- README.md | 9 +++++---- src/index.ts | 22 ++++++++++++---------- 2 files changed, 17 insertions(+), 14 deletions(-) diff --git a/README.md b/README.md index b42cae3..d1a463e 100644 --- a/README.md +++ b/README.md @@ -4,7 +4,7 @@ # [Binary Authorization: Node.js Client](https://github.com/googleapis/nodejs-binary-authorization) -[![release level](https://img.shields.io/badge/release%20level-preview-yellow.svg?style=flat)](https://cloud.google.com/terms/launch-stages) +[![release level](https://img.shields.io/badge/release%20level-stable-brightgreen.svg?style=flat)](https://cloud.google.com/terms/launch-stages) [![npm version](https://img.shields.io/npm/v/@google-cloud/binary-authorization.svg)](https://www.npmjs.org/package/@google-cloud/binary-authorization) @@ -120,13 +120,14 @@ This library follows [Semantic Versioning](http://semver.org/). +This library is considered to be **stable**. The code surface will not change in backwards-incompatible ways +unless absolutely necessary (e.g. because of critical security issues) or with +an extensive deprecation period. Issues and requests against **stable** libraries +are addressed with the highest priority. -This library is considered to be in **preview**. This means it is still a -work-in-progress and under active development. Any release is subject to -backwards-incompatible changes at any time. More Information: [Google Cloud Platform Launch Stages][launch_stages] diff --git a/src/index.ts b/src/index.ts index 4a13f7a..f1d240b 100644 --- a/src/index.ts +++ b/src/index.ts @@ -19,24 +19,26 @@ import * as v1 from './v1'; import * as v1beta1 from './v1beta1'; -const BinauthzManagementServiceV1Beta1Client = - v1beta1.BinauthzManagementServiceV1Beta1Client; -type BinauthzManagementServiceV1Beta1Client = - v1beta1.BinauthzManagementServiceV1Beta1Client; -const SystemPolicyV1Beta1Client = v1beta1.SystemPolicyV1Beta1Client; -type SystemPolicyV1Beta1Client = v1beta1.SystemPolicyV1Beta1Client; +const BinauthzManagementServiceV1Client = v1.BinauthzManagementServiceV1Client; +type BinauthzManagementServiceV1Client = v1.BinauthzManagementServiceV1Client; +const SystemPolicyV1Client = v1.SystemPolicyV1Client; +type SystemPolicyV1Client = v1.SystemPolicyV1Client; +const ValidationHelperV1Client = v1.ValidationHelperV1Client; +type ValidationHelperV1Client = v1.ValidationHelperV1Client; export { v1, v1beta1, - BinauthzManagementServiceV1Beta1Client, - SystemPolicyV1Beta1Client, + BinauthzManagementServiceV1Client, + SystemPolicyV1Client, + ValidationHelperV1Client, }; export default { v1, v1beta1, - BinauthzManagementServiceV1Beta1Client, - SystemPolicyV1Beta1Client, + BinauthzManagementServiceV1Client, + SystemPolicyV1Client, + ValidationHelperV1Client, }; import * as protos from '../protos/protos'; export {protos}; From a241c26d50ed8e691367c93974bfb43d7137ec19 Mon Sep 17 00:00:00 2001 From: Sofia Leon Date: Wed, 18 May 2022 18:03:35 -0700 Subject: [PATCH 3/7] fix samples --- samples/test/quickstart.js | 4 ++-- system-test/fixtures/sample/src/index.js | 8 ++++---- system-test/fixtures/sample/src/index.ts | 12 ++++++------ 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/samples/test/quickstart.js b/samples/test/quickstart.js index 4860971..70b6384 100644 --- a/samples/test/quickstart.js +++ b/samples/test/quickstart.js @@ -20,7 +20,7 @@ const cp = require('child_process'); const {before, describe, it} = require('mocha'); const { - BinauthzManagementServiceV1Beta1Client, + BinauthzManagementServiceV1Client, } = require('@google-cloud/binary-authorization'); const {assert} = require('chai'); @@ -30,7 +30,7 @@ describe('Quickstart', () => { let projectId; before(async () => { - const client = new BinauthzManagementServiceV1Beta1Client(); + const client = new BinauthzManagementServiceV1Client(); projectId = await client.getProjectId(); }); diff --git a/system-test/fixtures/sample/src/index.js b/system-test/fixtures/sample/src/index.js index 4a370ed..302b412 100644 --- a/system-test/fixtures/sample/src/index.js +++ b/system-test/fixtures/sample/src/index.js @@ -20,10 +20,10 @@ const binaryauthorization = require('@google-cloud/binary-authorization'); function main() { - const binauthzManagementServiceV1Beta1Client = - new binaryauthorization.BinauthzManagementServiceV1Beta1Client(); - const systemPolicyV1Beta1Client = - new binaryauthorization.SystemPolicyV1Beta1Client(); + const binauthzManagementServiceV1Client = + new binaryauthorization.BinauthzManagementServiceV1Client(); + const systemPolicyV1Client = + new binaryauthorization.SystemPolicyV1Client(); } main(); diff --git a/system-test/fixtures/sample/src/index.ts b/system-test/fixtures/sample/src/index.ts index 1f2222b..47b9693 100644 --- a/system-test/fixtures/sample/src/index.ts +++ b/system-test/fixtures/sample/src/index.ts @@ -17,18 +17,18 @@ // ** All changes to this file may be overwritten. ** import { - BinauthzManagementServiceV1Beta1Client, - SystemPolicyV1Beta1Client, + BinauthzManagementServiceV1Client, + SystemPolicyV1Client, } from '@google-cloud/binary-authorization'; // check that the client class type name can be used function doStuffWithBinauthzManagementServiceV1Beta1Client( - client: BinauthzManagementServiceV1Beta1Client + client: BinauthzManagementServiceV1Client ) { client.close(); } function doStuffWithSystemPolicyV1Beta1Client( - client: SystemPolicyV1Beta1Client + client: SystemPolicyV1Client ) { client.close(); } @@ -36,12 +36,12 @@ function doStuffWithSystemPolicyV1Beta1Client( function main() { // check that the client instance can be created const binauthzManagementServiceV1Beta1Client = - new BinauthzManagementServiceV1Beta1Client(); + new BinauthzManagementServiceV1Client(); doStuffWithBinauthzManagementServiceV1Beta1Client( binauthzManagementServiceV1Beta1Client ); // check that the client instance can be created - const systemPolicyV1Beta1Client = new SystemPolicyV1Beta1Client(); + const systemPolicyV1Beta1Client = new SystemPolicyV1Client(); doStuffWithSystemPolicyV1Beta1Client(systemPolicyV1Beta1Client); } From 0605ca694d5a7ad3d594c5031b7e3f63c27be1b8 Mon Sep 17 00:00:00 2001 From: Owl Bot Date: Thu, 19 May 2022 01:05:14 +0000 Subject: [PATCH 4/7] =?UTF-8?q?=F0=9F=A6=89=20Updates=20from=20OwlBot=20po?= =?UTF-8?q?st-processor?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --- system-test/fixtures/sample/src/index.js | 3 +-- system-test/fixtures/sample/src/index.ts | 4 +--- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/system-test/fixtures/sample/src/index.js b/system-test/fixtures/sample/src/index.js index 302b412..d9f317c 100644 --- a/system-test/fixtures/sample/src/index.js +++ b/system-test/fixtures/sample/src/index.js @@ -22,8 +22,7 @@ const binaryauthorization = require('@google-cloud/binary-authorization'); function main() { const binauthzManagementServiceV1Client = new binaryauthorization.BinauthzManagementServiceV1Client(); - const systemPolicyV1Client = - new binaryauthorization.SystemPolicyV1Client(); + const systemPolicyV1Client = new binaryauthorization.SystemPolicyV1Client(); } main(); diff --git a/system-test/fixtures/sample/src/index.ts b/system-test/fixtures/sample/src/index.ts index 47b9693..15cb8ef 100644 --- a/system-test/fixtures/sample/src/index.ts +++ b/system-test/fixtures/sample/src/index.ts @@ -27,9 +27,7 @@ function doStuffWithBinauthzManagementServiceV1Beta1Client( ) { client.close(); } -function doStuffWithSystemPolicyV1Beta1Client( - client: SystemPolicyV1Client -) { +function doStuffWithSystemPolicyV1Beta1Client(client: SystemPolicyV1Client) { client.close(); } From d1dad6e02640f432f13c6cacbff2a579c833f5f1 Mon Sep 17 00:00:00 2001 From: Sofia Leon Date: Wed, 18 May 2022 18:19:59 -0700 Subject: [PATCH 5/7] run lint --- system-test/fixtures/sample/src/index.js | 3 +-- system-test/fixtures/sample/src/index.ts | 9 ++++----- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/system-test/fixtures/sample/src/index.js b/system-test/fixtures/sample/src/index.js index d9f317c..b65b85e 100644 --- a/system-test/fixtures/sample/src/index.js +++ b/system-test/fixtures/sample/src/index.js @@ -20,8 +20,7 @@ const binaryauthorization = require('@google-cloud/binary-authorization'); function main() { - const binauthzManagementServiceV1Client = - new binaryauthorization.BinauthzManagementServiceV1Client(); + const binauthzManagementServiceV1Client = new binaryauthorization.BinauthzManagementServiceV1Client(); const systemPolicyV1Client = new binaryauthorization.SystemPolicyV1Client(); } diff --git a/system-test/fixtures/sample/src/index.ts b/system-test/fixtures/sample/src/index.ts index 15cb8ef..8d78159 100644 --- a/system-test/fixtures/sample/src/index.ts +++ b/system-test/fixtures/sample/src/index.ts @@ -27,20 +27,19 @@ function doStuffWithBinauthzManagementServiceV1Beta1Client( ) { client.close(); } -function doStuffWithSystemPolicyV1Beta1Client(client: SystemPolicyV1Client) { +function doStuffWithSystemPolicyV1Client(client: SystemPolicyV1Client) { client.close(); } function main() { // check that the client instance can be created - const binauthzManagementServiceV1Beta1Client = - new BinauthzManagementServiceV1Client(); + const binauthzManagementServiceV1Client = new BinauthzManagementServiceV1Client(); doStuffWithBinauthzManagementServiceV1Beta1Client( - binauthzManagementServiceV1Beta1Client + binauthzManagementServiceV1Client ); // check that the client instance can be created const systemPolicyV1Beta1Client = new SystemPolicyV1Client(); - doStuffWithSystemPolicyV1Beta1Client(systemPolicyV1Beta1Client); + doStuffWithSystemPolicyV1Client(systemPolicyV1Beta1Client); } main(); From 1610d954a0f300c9ec76a065e9da0a577e35be31 Mon Sep 17 00:00:00 2001 From: Sofia Leon Date: Wed, 18 May 2022 18:14:59 -0700 Subject: [PATCH 6/7] fix exports --- samples/quickstart.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/samples/quickstart.js b/samples/quickstart.js index 4fd18f4..9590ea4 100644 --- a/samples/quickstart.js +++ b/samples/quickstart.js @@ -19,14 +19,14 @@ async function main(parent) { // eslint-disable-next-line node/no-missing-require const { - BinauthzManagementServiceV1Beta1Client, + BinauthzManagementServiceV1Client, } = require('@google-cloud/binary-authorization'); // TODO(developer): replace with your prefered project ID. // const projectId = 'my-project' // Creates a client - const client = new BinauthzManagementServiceV1Beta1Client(); + const client = new BinauthzManagementServiceV1Client(); async function listAttestors() { const attestors = await client.listAttestors({parent}); From d9a13195c46e570dda2fbeb0d25e1892c8cd0b40 Mon Sep 17 00:00:00 2001 From: Owl Bot Date: Thu, 19 May 2022 01:23:34 +0000 Subject: [PATCH 7/7] =?UTF-8?q?=F0=9F=A6=89=20Updates=20from=20OwlBot=20po?= =?UTF-8?q?st-processor?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --- README.md | 4 ++-- system-test/fixtures/sample/src/index.js | 3 ++- system-test/fixtures/sample/src/index.ts | 3 ++- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index d1a463e..e67c729 100644 --- a/README.md +++ b/README.md @@ -61,14 +61,14 @@ npm install @google-cloud/binary-authorization // eslint-disable-next-line node/no-missing-require const { - BinauthzManagementServiceV1Beta1Client, + BinauthzManagementServiceV1Client, } = require('@google-cloud/binary-authorization'); // TODO(developer): replace with your prefered project ID. // const projectId = 'my-project' // Creates a client -const client = new BinauthzManagementServiceV1Beta1Client(); +const client = new BinauthzManagementServiceV1Client(); async function listAttestors() { const attestors = await client.listAttestors({parent}); diff --git a/system-test/fixtures/sample/src/index.js b/system-test/fixtures/sample/src/index.js index b65b85e..d9f317c 100644 --- a/system-test/fixtures/sample/src/index.js +++ b/system-test/fixtures/sample/src/index.js @@ -20,7 +20,8 @@ const binaryauthorization = require('@google-cloud/binary-authorization'); function main() { - const binauthzManagementServiceV1Client = new binaryauthorization.BinauthzManagementServiceV1Client(); + const binauthzManagementServiceV1Client = + new binaryauthorization.BinauthzManagementServiceV1Client(); const systemPolicyV1Client = new binaryauthorization.SystemPolicyV1Client(); } diff --git a/system-test/fixtures/sample/src/index.ts b/system-test/fixtures/sample/src/index.ts index 8d78159..866287d 100644 --- a/system-test/fixtures/sample/src/index.ts +++ b/system-test/fixtures/sample/src/index.ts @@ -33,7 +33,8 @@ function doStuffWithSystemPolicyV1Client(client: SystemPolicyV1Client) { function main() { // check that the client instance can be created - const binauthzManagementServiceV1Client = new BinauthzManagementServiceV1Client(); + const binauthzManagementServiceV1Client = + new BinauthzManagementServiceV1Client(); doStuffWithBinauthzManagementServiceV1Beta1Client( binauthzManagementServiceV1Client );