From 32c2b9dc24caf7048a983dc6179d0216643c95c1 Mon Sep 17 00:00:00 2001 From: Sofia Leon Date: Wed, 2 Jun 2021 12:22:23 -0500 Subject: [PATCH 01/10] add to gitignore --- .github/.OwlBot.lock.yaml | 2 +- .gitignore | 15 ++++++++++++++- samples/quickstart.js | 12 +++++------- samples/test/quickstart.js | 13 ++++--------- 4 files changed, 24 insertions(+), 18 deletions(-) diff --git a/.github/.OwlBot.lock.yaml b/.github/.OwlBot.lock.yaml index 3be1fcf..97b16a1 100644 --- a/.github/.OwlBot.lock.yaml +++ b/.github/.OwlBot.lock.yaml @@ -13,5 +13,5 @@ # limitations under the License. docker: - digest: sha256:c3eae37a355402067b97cbeb6f5a7d2dd87aecfd064aeb2d2ea0bde40778cf68 + digest: sha256:f556e6e7be625deb1b2429fe608df27be57185c3e6b7d39ee0059f1609f17530 image: gcr.io/repo-automation-bots/owlbot-nodejs:latest diff --git a/.gitignore b/.gitignore index 7525967..f73bce1 100644 --- a/.gitignore +++ b/.gitignore @@ -1,2 +1,15 @@ +**/*.log +**/node_modules +.coverage +coverage +.nyc_output +docs/ +out/ build/ -node_modules +system-test/secrets.js +system-test/*key.json +*.lock +.DS_Store +package-lock.json +__pycache__ +owl-bot-staging \ No newline at end of file diff --git a/samples/quickstart.js b/samples/quickstart.js index 67378b9..cab8b8d 100644 --- a/samples/quickstart.js +++ b/samples/quickstart.js @@ -27,16 +27,14 @@ async function main() { // Creates a client // eslint-disable-next-line no-unused-vars - const client = new {CloudShellServiceClient}(); + const client = new CloudShellServiceClient(); //TODO(library generator): write the actual function you will be testing - async function doSomething() { - console.log('DPE! Change this code so that it shows how to use the library! See comments below on structure.') - // const [thing] = await client.methodName({ - // }); - // console.info(thing); + async function initializeClient() { + const operation = await client.initialize(); + console.info(operation); } - doSomething(); + initializeClient(); // [END nodejs_cloud_shell_quickstart] } diff --git a/samples/test/quickstart.js b/samples/test/quickstart.js index 6c2d120..d5ffd5e 100644 --- a/samples/test/quickstart.js +++ b/samples/test/quickstart.js @@ -29,10 +29,10 @@ const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'}); const cwd = path.join(__dirname, '..'); -const client = new {CloudShellServiceClient}(); +const client = new CloudShellServiceClient(); describe('Quickstart', () => { - //TODO: remove this if not using the projectId + //TODO: remove this if not using the projectId // eslint-disable-next-line no-unused-vars let projectId; @@ -42,12 +42,7 @@ describe('Quickstart', () => { }); it('should run quickstart', async () => { - //TODO: remove this line - // eslint-disable-next-line no-unused-vars - const stdout = execSync( - `node ./quickstart.js`, - {cwd} - ); - //assert(stdout, stdout !== null); + const stdout = execSync('node ./quickstart.js', {cwd}); + assert.match(stdout, /ServiceClientImpl/); }); }); From 0ef797cdf2c827cedc2003a0ebcc5146942e0a05 Mon Sep 17 00:00:00 2001 From: Sofia Leon Date: Wed, 2 Jun 2021 12:25:19 -0500 Subject: [PATCH 02/10] fix: add jsdoc --- .jsdoc.js | 55 ++++++++++++++++++++++++++++++++++++++++++ linkinator.config.json | 2 +- 2 files changed, 56 insertions(+), 1 deletion(-) create mode 100644 .jsdoc.js diff --git a/.jsdoc.js b/.jsdoc.js new file mode 100644 index 0000000..f5fcaab --- /dev/null +++ b/.jsdoc.js @@ -0,0 +1,55 @@ +// Copyright 2021 Google LLC +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// https://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. +// +// ** This file is automatically generated by gapic-generator-typescript. ** +// ** https://github.com/googleapis/gapic-generator-typescript ** +// ** All changes to this file may be overwritten. ** + +'use strict'; + +module.exports = { + opts: { + readme: './README.md', + package: './package.json', + template: './node_modules/jsdoc-fresh', + recurse: true, + verbose: true, + destination: './docs/' + }, + plugins: [ + 'plugins/markdown', + 'jsdoc-region-tag' + ], + source: { + excludePattern: '(^|\\/|\\\\)[._]', + include: [ + 'build/src', + 'protos' + ], + includePattern: '\\.js$' + }, + templates: { + copyright: 'Copyright 2021 Google LLC', + includeDate: false, + sourceFiles: false, + systemName: '@google-cloud/cloud-shell', + theme: 'lumen', + default: { + outputSourceFiles: false + } + }, + markdown: { + idInHeadings: true + } +}; \ No newline at end of file diff --git a/linkinator.config.json b/linkinator.config.json index 0947c2e..4e20973 100644 --- a/linkinator.config.json +++ b/linkinator.config.json @@ -1 +1 @@ -{"recurse":true,"skip":["https://codecov.io/gh/googleapis/","www.googleapis.com","img.shields.io"],"silent":true,"concurrency":10} \ No newline at end of file +{"recurse":true,"skip":["https://codecov.io/gh/googleapis/","https://github.com/googleapis/nodejs-cloud-shell/blob/master/CHANGELOG.md","www.googleapis.com","img.shields.io"],"silent":true,"concurrency":10} \ No newline at end of file From c6553a312dec57016805065c42b4ff7ea5e41f37 Mon Sep 17 00:00:00 2001 From: Sofia Leon Date: Wed, 2 Jun 2021 12:32:52 -0500 Subject: [PATCH 03/10] fix: remove empty comments --- samples/test/quickstart.js | 9 --------- 1 file changed, 9 deletions(-) diff --git a/samples/test/quickstart.js b/samples/test/quickstart.js index d5ffd5e..bff562a 100644 --- a/samples/test/quickstart.js +++ b/samples/test/quickstart.js @@ -32,15 +32,6 @@ const cwd = path.join(__dirname, '..'); const client = new CloudShellServiceClient(); describe('Quickstart', () => { - //TODO: remove this if not using the projectId - // eslint-disable-next-line no-unused-vars - let projectId; - - before(async () => { - // eslint-disable-next-line no-unused-vars - projectId = await client.getProjectId(); - }); - it('should run quickstart', async () => { const stdout = execSync('node ./quickstart.js', {cwd}); assert.match(stdout, /ServiceClientImpl/); From 06bb77514c62474735b0af8cc6d9c1a638d70db3 Mon Sep 17 00:00:00 2001 From: Owl Bot Date: Wed, 2 Jun 2021 17:33:59 +0000 Subject: [PATCH 04/10] =?UTF-8?q?=F0=9F=A6=89=20Updates=20from=20OwlBot?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .github/workflows/ci.yaml | 2 +- README.md | 44 ++++++++++++++++++++++++++++++---- samples/README.md | 50 +++++++++++++++++++++++++++++++++++++++ samples/quickstart.js | 1 - 4 files changed, 90 insertions(+), 7 deletions(-) create mode 100644 samples/README.md diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index dbcdc7c..a295b44 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -1,7 +1,7 @@ on: push: branches: - - master + - main pull_request: name: ci jobs: diff --git a/README.md b/README.md index d0624d1..98dd0c0 100644 --- a/README.md +++ b/README.md @@ -15,7 +15,7 @@ cloudshell client for Node.js A comprehensive list of changes in each version may be found in -[the CHANGELOG](https://github.com/googleapis/nodejs-cloud-shell/blob/master/CHANGELOG.md). +[the CHANGELOG](https://github.com/googleapis/nodejs-cloud-shell/blob/main/CHANGELOG.md). * [Cloud Shell Node.js Client API Reference][client-docs] * [Cloud Shell Documentation][product-docs] @@ -32,8 +32,8 @@ Google APIs Client Libraries, in [Client Libraries Explained][explained]. * [Quickstart](#quickstart) * [Before you begin](#before-you-begin) * [Installing the client library](#installing-the-client-library) - - + * [Using the client library](#using-the-client-library) +* [Samples](#samples) * [Versioning](#versioning) * [Contributing](#contributing) * [License](#license) @@ -55,6 +55,40 @@ npm install @google-cloud/cloud-shell ``` +### Using the client library + +```javascript +// Imports the Google Cloud client library + +// remove this line after package is released +// eslint-disable-next-line node/no-missing-require +const {CloudShellServiceClient} = require('@google-cloud/cloud-shell'); + +// TODO(developer): replace with your prefered project ID. +// const projectId = 'my-project' + +// Creates a client +// eslint-disable-next-line no-unused-vars +const client = new CloudShellServiceClient(); + +//TODO(library generator): write the actual function you will be testing +async function initializeClient() { + const operation = await client.initialize(); + console.info(operation); +} +initializeClient(); + +``` + + + +## Samples + +Samples are in the [`samples/`](https://github.com/googleapis/nodejs-cloud-shell/tree/main/samples) directory. Each sample's `README.md` has instructions for running its sample. + +| Sample | Source Code | Try it | +| --------------------------- | --------------------------------- | ------ | +| Quickstart | [source code](https://github.com/googleapis/nodejs-cloud-shell/blob/main/samples/quickstart.js) | [![Open in Cloud Shell][shell_img]](https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/nodejs-cloud-shell&page=editor&open_in_editor=samples/quickstart.js,samples/README.md) | @@ -97,7 +131,7 @@ More Information: [Google Cloud Platform Launch Stages][launch_stages] ## Contributing -Contributions welcome! See the [Contributing Guide](https://github.com/googleapis/nodejs-cloud-shell/blob/master/CONTRIBUTING.md). +Contributions welcome! See the [Contributing Guide](https://github.com/googleapis/nodejs-cloud-shell/blob/main/CONTRIBUTING.md). Please note that this `README.md`, the `samples/README.md`, and a variety of configuration files in this repository (including `.nycrc` and `tsconfig.json`) @@ -109,7 +143,7 @@ to its template in this Apache Version 2.0 -See [LICENSE](https://github.com/googleapis/nodejs-cloud-shell/blob/master/LICENSE) +See [LICENSE](https://github.com/googleapis/nodejs-cloud-shell/blob/main/LICENSE) [client-docs]: https://cloud.google.com/shell/docs/reference/rest [product-docs]: https://cloud.google.com/shell/ diff --git a/samples/README.md b/samples/README.md new file mode 100644 index 0000000..ab33be3 --- /dev/null +++ b/samples/README.md @@ -0,0 +1,50 @@ +[//]: # "This README.md file is auto-generated, all changes to this file will be lost." +[//]: # "To regenerate it, use `python -m synthtool`." +Google Cloud Platform logo + +# [Cloud Shell: Node.js Samples](https://github.com/googleapis/nodejs-cloud-shell) + +[![Open in Cloud Shell][shell_img]][shell_link] + + + +## Table of Contents + +* [Before you begin](#before-you-begin) +* [Samples](#samples) + * [Quickstart](#quickstart) + +## Before you begin + +Before running the samples, make sure you've followed the steps outlined in +[Using the client library](https://github.com/googleapis/nodejs-cloud-shell#using-the-client-library). + +`cd samples` + +`npm install` + +`cd ..` + +## Samples + + + +### Quickstart + +View the [source code](https://github.com/googleapis/nodejs-cloud-shell/blob/main/samples/quickstart.js). + +[![Open in Cloud Shell][shell_img]](https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/nodejs-cloud-shell&page=editor&open_in_editor=samples/quickstart.js,samples/README.md) + +__Usage:__ + + +`node samples/quickstart.js` + + + + + + +[shell_img]: https://gstatic.com/cloudssh/images/open-btn.png +[shell_link]: https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/nodejs-cloud-shell&page=editor&open_in_editor=samples/README.md +[product-docs]: https://cloud.google.com/shell/ diff --git a/samples/quickstart.js b/samples/quickstart.js index cab8b8d..70d4528 100644 --- a/samples/quickstart.js +++ b/samples/quickstart.js @@ -14,7 +14,6 @@ 'use strict'; async function main() { - // [START nodejs_cloud_shell_quickstart] // Imports the Google Cloud client library From f79c3402fd56617ab4db99d5abaa8278947c0e8c Mon Sep 17 00:00:00 2001 From: Sofia Leon Date: Wed, 2 Jun 2021 13:09:48 -0500 Subject: [PATCH 05/10] fix: rerun owlbot --- README.md | 38 ++++++++++++++++++++++++++++++-- linkinator.config.json | 11 +++++++++- samples/README.md | 50 ++++++++++++++++++++++++++++++++++++++++++ samples/quickstart.js | 1 - 4 files changed, 96 insertions(+), 4 deletions(-) create mode 100644 samples/README.md diff --git a/README.md b/README.md index d0624d1..efee2b2 100644 --- a/README.md +++ b/README.md @@ -32,8 +32,8 @@ Google APIs Client Libraries, in [Client Libraries Explained][explained]. * [Quickstart](#quickstart) * [Before you begin](#before-you-begin) * [Installing the client library](#installing-the-client-library) - - + * [Using the client library](#using-the-client-library) +* [Samples](#samples) * [Versioning](#versioning) * [Contributing](#contributing) * [License](#license) @@ -55,6 +55,40 @@ npm install @google-cloud/cloud-shell ``` +### Using the client library + +```javascript +// Imports the Google Cloud client library + +// remove this line after package is released +// eslint-disable-next-line node/no-missing-require +const {CloudShellServiceClient} = require('@google-cloud/cloud-shell'); + +// TODO(developer): replace with your prefered project ID. +// const projectId = 'my-project' + +// Creates a client +// eslint-disable-next-line no-unused-vars +const client = new CloudShellServiceClient(); + +//TODO(library generator): write the actual function you will be testing +async function initializeClient() { + const operation = await client.initialize(); + console.info(operation); +} +initializeClient(); + +``` + + + +## Samples + +Samples are in the [`samples/`](https://github.com/googleapis/nodejs-cloud-shell/tree/master/samples) directory. Each sample's `README.md` has instructions for running its sample. + +| Sample | Source Code | Try it | +| --------------------------- | --------------------------------- | ------ | +| Quickstart | [source code](https://github.com/googleapis/nodejs-cloud-shell/blob/master/samples/quickstart.js) | [![Open in Cloud Shell][shell_img]](https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/nodejs-cloud-shell&page=editor&open_in_editor=samples/quickstart.js,samples/README.md) | diff --git a/linkinator.config.json b/linkinator.config.json index 4e20973..29a223b 100644 --- a/linkinator.config.json +++ b/linkinator.config.json @@ -1 +1,10 @@ -{"recurse":true,"skip":["https://codecov.io/gh/googleapis/","https://github.com/googleapis/nodejs-cloud-shell/blob/master/CHANGELOG.md","www.googleapis.com","img.shields.io"],"silent":true,"concurrency":10} \ No newline at end of file +{ + "recurse": true, + "skip": [ + "https://codecov.io/gh/googleapis/", + "www.googleapis.com", + "img.shields.io" + ], + "silent": true, + "concurrency": 10 +} diff --git a/samples/README.md b/samples/README.md new file mode 100644 index 0000000..9ef84fa --- /dev/null +++ b/samples/README.md @@ -0,0 +1,50 @@ +[//]: # "This README.md file is auto-generated, all changes to this file will be lost." +[//]: # "To regenerate it, use `python -m synthtool`." +Google Cloud Platform logo + +# [Cloud Shell: Node.js Samples](https://github.com/googleapis/nodejs-cloud-shell) + +[![Open in Cloud Shell][shell_img]][shell_link] + + + +## Table of Contents + +* [Before you begin](#before-you-begin) +* [Samples](#samples) + * [Quickstart](#quickstart) + +## Before you begin + +Before running the samples, make sure you've followed the steps outlined in +[Using the client library](https://github.com/googleapis/nodejs-cloud-shell#using-the-client-library). + +`cd samples` + +`npm install` + +`cd ..` + +## Samples + + + +### Quickstart + +View the [source code](https://github.com/googleapis/nodejs-cloud-shell/blob/master/samples/quickstart.js). + +[![Open in Cloud Shell][shell_img]](https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/nodejs-cloud-shell&page=editor&open_in_editor=samples/quickstart.js,samples/README.md) + +__Usage:__ + + +`node samples/quickstart.js` + + + + + + +[shell_img]: https://gstatic.com/cloudssh/images/open-btn.png +[shell_link]: https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/nodejs-cloud-shell&page=editor&open_in_editor=samples/README.md +[product-docs]: https://cloud.google.com/shell/ diff --git a/samples/quickstart.js b/samples/quickstart.js index cab8b8d..70d4528 100644 --- a/samples/quickstart.js +++ b/samples/quickstart.js @@ -14,7 +14,6 @@ 'use strict'; async function main() { - // [START nodejs_cloud_shell_quickstart] // Imports the Google Cloud client library From 011d88f0a790622c7bb6127f7b8bae608af17559 Mon Sep 17 00:00:00 2001 From: Owl Bot Date: Wed, 2 Jun 2021 18:11:44 +0000 Subject: [PATCH 06/10] =?UTF-8?q?=F0=9F=A6=89=20Updates=20from=20OwlBot?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- README.md | 8 -------- samples/README.md | 4 ---- 2 files changed, 12 deletions(-) diff --git a/README.md b/README.md index 99adb28..98dd0c0 100644 --- a/README.md +++ b/README.md @@ -84,19 +84,11 @@ initializeClient(); ## Samples -<<<<<<< HEAD -Samples are in the [`samples/`](https://github.com/googleapis/nodejs-cloud-shell/tree/master/samples) directory. Each sample's `README.md` has instructions for running its sample. - -| Sample | Source Code | Try it | -| --------------------------- | --------------------------------- | ------ | -| Quickstart | [source code](https://github.com/googleapis/nodejs-cloud-shell/blob/master/samples/quickstart.js) | [![Open in Cloud Shell][shell_img]](https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/nodejs-cloud-shell&page=editor&open_in_editor=samples/quickstart.js,samples/README.md) | -======= Samples are in the [`samples/`](https://github.com/googleapis/nodejs-cloud-shell/tree/main/samples) directory. Each sample's `README.md` has instructions for running its sample. | Sample | Source Code | Try it | | --------------------------- | --------------------------------- | ------ | | Quickstart | [source code](https://github.com/googleapis/nodejs-cloud-shell/blob/main/samples/quickstart.js) | [![Open in Cloud Shell][shell_img]](https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/nodejs-cloud-shell&page=editor&open_in_editor=samples/quickstart.js,samples/README.md) | ->>>>>>> 06bb77514c62474735b0af8cc6d9c1a638d70db3 diff --git a/samples/README.md b/samples/README.md index 9da9f21..ab33be3 100644 --- a/samples/README.md +++ b/samples/README.md @@ -31,11 +31,7 @@ Before running the samples, make sure you've followed the steps outlined in ### Quickstart -<<<<<<< HEAD -View the [source code](https://github.com/googleapis/nodejs-cloud-shell/blob/master/samples/quickstart.js). -======= View the [source code](https://github.com/googleapis/nodejs-cloud-shell/blob/main/samples/quickstart.js). ->>>>>>> 06bb77514c62474735b0af8cc6d9c1a638d70db3 [![Open in Cloud Shell][shell_img]](https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/nodejs-cloud-shell&page=editor&open_in_editor=samples/quickstart.js,samples/README.md) From c1420f977f76505c4362e8f7e849f0b647654c11 Mon Sep 17 00:00:00 2001 From: Sofia Leon Date: Wed, 2 Jun 2021 14:32:43 -0500 Subject: [PATCH 07/10] fix: sample --- samples/test/quickstart.js | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/samples/test/quickstart.js b/samples/test/quickstart.js index bff562a..8641016 100644 --- a/samples/test/quickstart.js +++ b/samples/test/quickstart.js @@ -19,18 +19,13 @@ const path = require('path'); const cp = require('child_process'); -const {before, describe, it} = require('mocha'); -// eslint-disable-next-line node/no-missing-require -const {CloudShellServiceClient} = require('@google-cloud/cloud-shell'); -// eslint-disable-next-line no-unused-vars, node/no-missing-require +const {describe, it} = require('mocha'); const {assert} = require('chai'); const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'}); const cwd = path.join(__dirname, '..'); -const client = new CloudShellServiceClient(); - describe('Quickstart', () => { it('should run quickstart', async () => { const stdout = execSync('node ./quickstart.js', {cwd}); From c37aff626d6c256c1ff4cbc909011c72c225ccc2 Mon Sep 17 00:00:00 2001 From: Sofia Leon Date: Wed, 2 Jun 2021 14:34:59 -0500 Subject: [PATCH 08/10] fix: change main to master --- .github/workflows/ci.yaml | 2 +- README.md | 10 +++++----- samples/README.md | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index a295b44..dbcdc7c 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -1,7 +1,7 @@ on: push: branches: - - main + - master pull_request: name: ci jobs: diff --git a/README.md b/README.md index 99adb28..0242e1e 100644 --- a/README.md +++ b/README.md @@ -15,7 +15,7 @@ cloudshell client for Node.js A comprehensive list of changes in each version may be found in -[the CHANGELOG](https://github.com/googleapis/nodejs-cloud-shell/blob/main/CHANGELOG.md). +[the CHANGELOG](https://github.com/googleapis/nodejs-cloud-shell/blob/master/CHANGELOG.md). * [Cloud Shell Node.js Client API Reference][client-docs] * [Cloud Shell Documentation][product-docs] @@ -91,11 +91,11 @@ Samples are in the [`samples/`](https://github.com/googleapis/nodejs-cloud-shell | --------------------------- | --------------------------------- | ------ | | Quickstart | [source code](https://github.com/googleapis/nodejs-cloud-shell/blob/master/samples/quickstart.js) | [![Open in Cloud Shell][shell_img]](https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/nodejs-cloud-shell&page=editor&open_in_editor=samples/quickstart.js,samples/README.md) | ======= -Samples are in the [`samples/`](https://github.com/googleapis/nodejs-cloud-shell/tree/main/samples) directory. Each sample's `README.md` has instructions for running its sample. +Samples are in the [`samples/`](https://github.com/googleapis/nodejs-cloud-shell/tree/master/samples) directory. Each sample's `README.md` has instructions for running its sample. | Sample | Source Code | Try it | | --------------------------- | --------------------------------- | ------ | -| Quickstart | [source code](https://github.com/googleapis/nodejs-cloud-shell/blob/main/samples/quickstart.js) | [![Open in Cloud Shell][shell_img]](https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/nodejs-cloud-shell&page=editor&open_in_editor=samples/quickstart.js,samples/README.md) | +| Quickstart | [source code](https://github.com/googleapis/nodejs-cloud-shell/blob/master/samples/quickstart.js) | [![Open in Cloud Shell][shell_img]](https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/nodejs-cloud-shell&page=editor&open_in_editor=samples/quickstart.js,samples/README.md) | >>>>>>> 06bb77514c62474735b0af8cc6d9c1a638d70db3 @@ -139,7 +139,7 @@ More Information: [Google Cloud Platform Launch Stages][launch_stages] ## Contributing -Contributions welcome! See the [Contributing Guide](https://github.com/googleapis/nodejs-cloud-shell/blob/main/CONTRIBUTING.md). +Contributions welcome! See the [Contributing Guide](https://github.com/googleapis/nodejs-cloud-shell/blob/master/CONTRIBUTING.md). Please note that this `README.md`, the `samples/README.md`, and a variety of configuration files in this repository (including `.nycrc` and `tsconfig.json`) @@ -151,7 +151,7 @@ to its template in this Apache Version 2.0 -See [LICENSE](https://github.com/googleapis/nodejs-cloud-shell/blob/main/LICENSE) +See [LICENSE](https://github.com/googleapis/nodejs-cloud-shell/blob/master/LICENSE) [client-docs]: https://cloud.google.com/shell/docs/reference/rest [product-docs]: https://cloud.google.com/shell/ diff --git a/samples/README.md b/samples/README.md index 9da9f21..d082f5a 100644 --- a/samples/README.md +++ b/samples/README.md @@ -34,7 +34,7 @@ Before running the samples, make sure you've followed the steps outlined in <<<<<<< HEAD View the [source code](https://github.com/googleapis/nodejs-cloud-shell/blob/master/samples/quickstart.js). ======= -View the [source code](https://github.com/googleapis/nodejs-cloud-shell/blob/main/samples/quickstart.js). +View the [source code](https://github.com/googleapis/nodejs-cloud-shell/blob/master/samples/quickstart.js). >>>>>>> 06bb77514c62474735b0af8cc6d9c1a638d70db3 [![Open in Cloud Shell][shell_img]](https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/nodejs-cloud-shell&page=editor&open_in_editor=samples/quickstart.js,samples/README.md) From 9e986c5e8c14e7d931b8fabcc0fb672ebf482208 Mon Sep 17 00:00:00 2001 From: Sofia Leon Date: Wed, 2 Jun 2021 15:18:01 -0500 Subject: [PATCH 09/10] fix: engine --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 5213109..5a39c2c 100644 --- a/package.json +++ b/package.json @@ -61,6 +61,6 @@ "webpack-cli": "^4.7.0" }, "engines": { - "node": ">=v12.0.0" + "node": ">=v10.0.0" } } From 3a80924d2d70385c4fd5a1d705538b0b58180ab0 Mon Sep 17 00:00:00 2001 From: Sofia Leon Date: Wed, 2 Jun 2021 16:14:44 -0500 Subject: [PATCH 10/10] fix: linkinator --- linkinator.config.json | 1 + 1 file changed, 1 insertion(+) diff --git a/linkinator.config.json b/linkinator.config.json index 29a223b..4e8e943 100644 --- a/linkinator.config.json +++ b/linkinator.config.json @@ -1,6 +1,7 @@ { "recurse": true, "skip": [ + "https://github.com/googleapis/nodejs-cloud-shell/blob/master/CHANGELOG.md", "https://codecov.io/gh/googleapis/", "www.googleapis.com", "img.shields.io"