New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to strip of undefined values #378

Open
moander opened this Issue Oct 7, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@moander

moander commented Oct 7, 2018

Hi,

Google Datastore ignores undefined values. Migrating to Firestore I must now update all writes (or the prototype) to strip of undefined values.

Error: Invalid use of type "undefined" as a Firestore argument

I think this will be a common error for people migrating from Datastore to Firestore so maybe it could be a part of the library?

I would also like to add that implementing this library was an awesome experience :D

Thank you!

@schmidt-sebastian

This comment has been minimized.

Show comment
Hide comment
@schmidt-sebastian

schmidt-sebastian Oct 15, 2018

Contributor

Can you tell us where you are hitting this issue? In calls to update or query? If it makes the migration easier, then we can certainly take a look at this.

Contributor

schmidt-sebastian commented Oct 15, 2018

Can you tell us where you are hitting this issue? In calls to update or query? If it makes the migration easier, then we can certainly take a look at this.

@moander

This comment has been minimized.

Show comment
Hide comment
@moander

moander Oct 17, 2018

I'm getting this from .set, .create, and .update

Reproduce code:

let b; 
firestore.doc('a/b').set({a:b});

moander commented Oct 17, 2018

I'm getting this from .set, .create, and .update

Reproduce code:

let b; 
firestore.doc('a/b').set({a:b});
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment