Skip to content

fix: Version 7 of protobufjs requires update.sh script to be fixed.#1766

Merged
tom-andersen merged 1 commit intomainfrom
tomandersen/fixUpdateProtoScript
Sep 7, 2022
Merged

fix: Version 7 of protobufjs requires update.sh script to be fixed.#1766
tom-andersen merged 1 commit intomainfrom
tomandersen/fixUpdateProtoScript

Conversation

@tom-andersen
Copy link
Contributor

No description provided.

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: firestore Issues related to the googleapis/nodejs-firestore API. labels Sep 7, 2022
@tom-andersen tom-andersen assigned dconeybe and unassigned cherylEnkidu Sep 7, 2022
@tom-andersen tom-andersen marked this pull request as ready for review September 7, 2022 18:35
@tom-andersen tom-andersen requested review from a team as code owners September 7, 2022 18:35
@tom-andersen tom-andersen added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 7, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 7, 2022
Copy link
Contributor

@alexander-fenster alexander-fenster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If possible, please make the PR title fit in 50 characters so that it looks pretty in the release notes :)

@tom-andersen tom-andersen changed the title fix: Version 7 of protobufjs broke the update.sh script. Added path t… fix: Version 7 of protobufjs requires update.sh script to be fixed. Sep 7, 2022
@tom-andersen tom-andersen merged commit 40f1db3 into main Sep 7, 2022
@tom-andersen tom-andersen deleted the tomandersen/fixUpdateProtoScript branch September 7, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore Issues related to the googleapis/nodejs-firestore API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants