From b4737c9bbcc677d175fc58f8057f23fab4312f5f Mon Sep 17 00:00:00 2001 From: sofisl <55454395+sofisl@users.noreply.github.com> Date: Fri, 16 Feb 2024 15:24:53 -0800 Subject: [PATCH 1/6] chore: update package.json Fix flaky test: https://github.com/compodoc/compodoc/issues/1422 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 182e587..78a0ae9 100644 --- a/package.json +++ b/package.json @@ -44,7 +44,7 @@ "walkdir": "^0.4.0" }, "devDependencies": { - "@compodoc/compodoc": "^1.1.9", + "@compodoc/compodoc": "1.1.9", "@types/mocha": "^9.0.0", "@types/node": "^20.4.9", "@types/proxyquire": "^1.3.28", From 118a9ade27e4a0b9152c6be7eb872aba07970085 Mon Sep 17 00:00:00 2001 From: sofisl <55454395+sofisl@users.noreply.github.com> Date: Fri, 16 Feb 2024 15:25:38 -0800 Subject: [PATCH 2/6] Update package.json --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 78a0ae9..052d06e 100644 --- a/package.json +++ b/package.json @@ -44,7 +44,7 @@ "walkdir": "^0.4.0" }, "devDependencies": { - "@compodoc/compodoc": "1.1.9", + "@compodoc/compodoc": "1.1.21", "@types/mocha": "^9.0.0", "@types/node": "^20.4.9", "@types/proxyquire": "^1.3.28", From 4a96756b3b1c0d34c7ed37446f0dde74e99bfb32 Mon Sep 17 00:00:00 2001 From: Sofia Leon Date: Tue, 20 Feb 2024 13:29:56 -0800 Subject: [PATCH 3/6] run tests From 3ec612395f6cc7dea4538f34d983eea0dcbaf4bb Mon Sep 17 00:00:00 2001 From: sofisl <55454395+sofisl@users.noreply.github.com> Date: Tue, 20 Feb 2024 14:39:42 -0800 Subject: [PATCH 4/6] Update package.json --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 052d06e..78a0ae9 100644 --- a/package.json +++ b/package.json @@ -44,7 +44,7 @@ "walkdir": "^0.4.0" }, "devDependencies": { - "@compodoc/compodoc": "1.1.21", + "@compodoc/compodoc": "1.1.9", "@types/mocha": "^9.0.0", "@types/node": "^20.4.9", "@types/proxyquire": "^1.3.28", From 2ce6082d33440cce39a271b9eb27fc74d090cba6 Mon Sep 17 00:00:00 2001 From: Sofia Leon Date: Tue, 20 Feb 2024 15:27:50 -0800 Subject: [PATCH 5/6] test: remove test relying on broken behavior in protobufjs --- package.json | 2 +- test/load.test.ts | 5 ----- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/package.json b/package.json index 052d06e..e53ef11 100644 --- a/package.json +++ b/package.json @@ -44,7 +44,7 @@ "walkdir": "^0.4.0" }, "devDependencies": { - "@compodoc/compodoc": "1.1.21", + "@compodoc/compodoc": "^1.1.21", "@types/mocha": "^9.0.0", "@types/node": "^20.4.9", "@types/proxyquire": "^1.3.28", diff --git a/test/load.test.ts b/test/load.test.ts index f8b7371..48ea29b 100644 --- a/test/load.test.ts +++ b/test/load.test.ts @@ -63,11 +63,6 @@ describe('loadSync', () => { '../../test/fixtures', 'library.proto' ); - it('should not be able to load test file using protobufjs directly', () => { - const root = protobuf.loadSync(TEST_FILE); - // Common proto that should not have been loaded. - assert.strictEqual(root.lookup('google.api.Http'), null); - }); it('should load a test file that relies on common protos', () => { const root = googleProtoFiles.loadSync(TEST_FILE); From f14173269d87149c5ae4cacabc53fd5258403d64 Mon Sep 17 00:00:00 2001 From: sofisl <55454395+sofisl@users.noreply.github.com> Date: Tue, 20 Feb 2024 15:35:43 -0800 Subject: [PATCH 6/6] Update package.json --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index e53ef11..182e587 100644 --- a/package.json +++ b/package.json @@ -44,7 +44,7 @@ "walkdir": "^0.4.0" }, "devDependencies": { - "@compodoc/compodoc": "^1.1.21", + "@compodoc/compodoc": "^1.1.9", "@types/mocha": "^9.0.0", "@types/node": "^20.4.9", "@types/proxyquire": "^1.3.28",