build: fix path-to-regexp #2108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xs
alkatrivedi
force-pushed
the
fix-build-path-regex-node-14
branch
3 times, most recently
from
e9e8387 to
6e1bab3
Compare
alkatrivedi
force-pushed
the
fix-build-path-regex-node-14
branch
from
6e1bab3 to
e6bf353
Compare
alkatrivedi
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
surbhigarg92
added
the
automerge
sofisl
approved these changes
Sep 12, 2024
gcf-merge-on-green
bot
removed
the
automerge
This was referenced Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sinon having dependency on the nise package. That package just published v6.0.1 which updated path-to-regexp from v6.2.1 to v8.1.0 with sinonjs/nise#226. That should have been a major version bump, as this ended up introducing a breaking change that now it depends on Node >= 16, which is causing our CI to break.
This PR fixes path-to-regexp to ^6.2.1 like previously to make it work on Node >= 14