From 10a0aab7f2e12e5818468c388e90369c0a6838ca Mon Sep 17 00:00:00 2001 From: Jonathan Lui Date: Tue, 29 Jan 2019 12:20:11 -0800 Subject: [PATCH 1/2] fix(ts): fix Storage.createBucket overloaded signature --- src/storage.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/storage.ts b/src/storage.ts index 7c6123387..c93e5923b 100644 --- a/src/storage.ts +++ b/src/storage.ts @@ -347,8 +347,9 @@ export class Storage extends Service { return new Channel(this, id, resourceId); } - createBucket(name: string): Promise; + createBucket(name: string, metadata?: CreateBucketRequest): Promise; createBucket(name: string, callback: BucketCallback): void; + createBucket(name: string, metadata: CreateBucketRequest, callback: BucketCallback): void; createBucket( name: string, metadata: CreateBucketRequest, callback: BucketCallback): void; From 3487d0b94c49d68ff1fc42443fbd32289493eb4a Mon Sep 17 00:00:00 2001 From: Jonathan Lui Date: Tue, 29 Jan 2019 12:25:02 -0800 Subject: [PATCH 2/2] gts fix --- src/storage.ts | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/storage.ts b/src/storage.ts index c93e5923b..dc280c396 100644 --- a/src/storage.ts +++ b/src/storage.ts @@ -347,9 +347,12 @@ export class Storage extends Service { return new Channel(this, id, resourceId); } - createBucket(name: string, metadata?: CreateBucketRequest): Promise; + createBucket(name: string, metadata?: CreateBucketRequest): + Promise; createBucket(name: string, callback: BucketCallback): void; - createBucket(name: string, metadata: CreateBucketRequest, callback: BucketCallback): void; + createBucket( + name: string, metadata: CreateBucketRequest, + callback: BucketCallback): void; createBucket( name: string, metadata: CreateBucketRequest, callback: BucketCallback): void;