-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add flag to allow disabling auto decompression by client #850
Merged
Merged
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
1d785af
feat: add flag to allow disabling auto decomression by client
AVaksman 421569c
refactor: rename returnCompressed default false to decompress default…
AVaksman b51a0a2
docs: fix
AVaksman 9c111dd
Merge branch 'master' into allow_return_compressed
AVaksman 78642ea
Merge branch 'master' into allow_return_compressed
AVaksman 8a3671b
Merge branch 'master' into allow_return_compressed
AVaksman 7f442ea
Merge branch 'master' into allow_return_compressed
AVaksman a657606
Merge branch 'master' into allow_return_compressed
AVaksman 579a053
Merge branch 'master' into allow_return_compressed
AVaksman 33be3be
Merge branch 'master' into allow_return_compressed
AVaksman f463908
Merge branch 'master' into allow_return_compressed
AVaksman be01018
fix: docs
AVaksman 23247c8
Merge branch 'master' into allow_return_compressed
AVaksman 489b4cd
fix: test description
AVaksman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this from the perspective of the GCS service?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, nodejs-sotage API always requests that the data should be served as is (compressed if applicable) i. e. sending appropriate headers
This flag is only from the perspective of nodejs-storage client to allow this library to not transcode the data if received from the server in compressed form and return to user compressed..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@frankyn ping!