New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding exception text to exit message for invalid clientsecrets #530

Merged
merged 1 commit into from Jun 29, 2016

Conversation

Projects
None yet
4 participants
@pferate
Contributor

pferate commented Jun 27, 2016

This is to address a problem found in googleapis/google-api-python-client#228.

This will give users the text from the InvalidClientSecretsError exception, in addition to the generic message that it currently does. The format of the message can be modified, if needed.

@googlebot googlebot added the cla: yes label Jun 27, 2016

@theacodes theacodes self-assigned this Jun 27, 2016

@theacodes

This comment has been minimized.

Show comment
Hide comment
@theacodes

theacodes Jun 27, 2016

Member

Thanks for this contribution. Do you mind adding or augmenting the existing test for this?

Member

theacodes commented Jun 27, 2016

Thanks for this contribution. Do you mind adding or augmenting the existing test for this?

@pferate

This comment has been minimized.

Show comment
Hide comment
@pferate

pferate Jun 28, 2016

Contributor

@jonparrott @nathanielmanistaatgoogle, I updated this PR again and added a test for this (slightly modified a previous test). Travis passed on my branch, but still waiting to launch for this PR.

I had to use positional argument specifiers in the .format() string to have it work with 2.6.

Contributor

pferate commented Jun 28, 2016

@jonparrott @nathanielmanistaatgoogle, I updated this PR again and added a test for this (slightly modified a previous test). Travis passed on my branch, but still waiting to launch for this PR.

I had to use positional argument specifiers in the .format() string to have it work with 2.6.

@theacodes

This comment has been minimized.

Show comment
Hide comment
@theacodes

theacodes Jun 28, 2016

Member

Great, this looks good to me. @nathanielmanistaatgoogle to do the final review.

Member

theacodes commented Jun 28, 2016

Great, this looks good to me. @nathanielmanistaatgoogle to do the final review.

@nathanielmanistaatgoogle

This comment has been minimized.

Show comment
Hide comment
@nathanielmanistaatgoogle
Contributor

nathanielmanistaatgoogle commented Jun 28, 2016

Add exception text to exit message
If `clientsecrets.InvalidClientSecretsError` is raised with additional
text and a predefined failure message is given, include exception text
in the exit message.
@pferate

This comment has been minimized.

Show comment
Hide comment
@pferate

pferate Jun 28, 2016

Contributor

Commit message updated.

Contributor

pferate commented Jun 28, 2016

Commit message updated.

@theacodes

This comment has been minimized.

Show comment
Hide comment
@theacodes

theacodes Jun 28, 2016

Member

Waiting for travis.

Member

theacodes commented Jun 28, 2016

Waiting for travis.

@theacodes theacodes merged commit a4e3431 into googleapis:master Jun 29, 2016

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@theacodes

This comment has been minimized.

Show comment
Hide comment
@theacodes

theacodes Jun 29, 2016

Member

Thanks for your contributions, @pferate!

Member

theacodes commented Jun 29, 2016

Thanks for your contributions, @pferate!

@pferate pferate deleted the pferate:clientsecret_message branch Jun 30, 2016

@theacodes theacodes referenced this pull request Jul 28, 2016

Merged

Release 3.0.0 #575

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment